Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 15221002: Add optional defaultEncoding to HttpBodyHandler, as a way to override default encoding for 'applica… (Closed)

Created:
7 years, 7 months ago by Anders Johnsen
Modified:
7 years, 7 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add optional defaultEncoding to HttpBodyHandler, as a way to override default encoding for 'application/x-www-form-urlencoded'. We should look into other places where defaultEncoding might make sense. BUG=http://code.google.com/p/dart/issues/detail?id=10649 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=22772

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -22 lines) Patch
M sdk/lib/io/http_body.dart View 1 chunk +21 lines, -5 lines 0 comments Download
M sdk/lib/io/http_body_impl.dart View 3 chunks +16 lines, -9 lines 0 comments Download
M sdk/lib/io/http_utils.dart View 1 3 chunks +9 lines, -5 lines 0 comments Download
M tests/standalone/io/http_body_test.dart View 4 chunks +21 lines, -3 lines 0 comments Download
M tests/standalone/io/url_encoding_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
7 years, 7 months ago (2013-05-16 06:21:10 UTC) #1
Søren Gjesse
lgtm https://codereview.chromium.org/15221002/diff/1/sdk/lib/io/http_body.dart File sdk/lib/io/http_body.dart (right): https://codereview.chromium.org/15221002/diff/1/sdk/lib/io/http_body.dart#newcode50 sdk/lib/io/http_body.dart:50: * 'application/x-www-form-urlencoded' content correctly. At some point we ...
7 years, 7 months ago (2013-05-16 07:13:58 UTC) #2
Anders Johnsen
https://codereview.chromium.org/15221002/diff/1/sdk/lib/io/http_body.dart File sdk/lib/io/http_body.dart (right): https://codereview.chromium.org/15221002/diff/1/sdk/lib/io/http_body.dart#newcode50 sdk/lib/io/http_body.dart:50: * 'application/x-www-form-urlencoded' content correctly. On 2013/05/16 07:13:58, Søren Gjesse ...
7 years, 7 months ago (2013-05-16 07:40:15 UTC) #3
Anders Johnsen
7 years, 7 months ago (2013-05-16 07:44:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r22772 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698