Add optional defaultEncoding to HttpBodyHandler, as a way to override default encoding for 'applica…

sdk/lib/io/http_body.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.io;
 
 
 /**
  * [HttpBodyHandler] is a helper class for parsing and collecting HTTP message
  * data in an easy-to-use [HttpBody] object. The content body is parsed,
@@ skipping 23 matching lines @@
  * The following mime-types will be handled specially:
  *   - text/\*
  *   - application/json
  *
  * All other mime-types will be returned as [List<int>].
  */
 class HttpBodyHandler
     implements StreamTransformer<HttpRequest, HttpRequestBody> {
   var _transformer;
 
-  HttpBodyHandler() : _transformer = new _HttpBodyHandlerTransformer();
+  /**
+   * Create a new [HttpBodyHandler] to be used with a [Stream]<[HttpRequest]>,
+   * e.g. a [HttpServer].
+   *
+   * If the page was served using different encoding than UTF-8, set
+   * [defaultEncoding] accordingly. This is required for parsing
+   * 'application/x-www-form-urlencoded' content correctly.

[Søren Gjesse, 2013/05/16 07:13:58]

At some point we should expand this comment and explain exactly which mime types
are handled.

[Anders Johnsen, 2013/05/16 07:40:16]

Yeah. This would be a nice cleanup along with the user-defined types.

+   */
+  HttpBodyHandler({Encoding defaultEncoding: Encoding.UTF_8})
+      : _transformer = new _HttpBodyHandlerTransformer(defaultEncoding);
 
   /**
    * Process and parse an incoming [HttpRequest]. The returned [HttpRequestBody]
    * contains a [response] field for accessing the [HttpResponse].
+   *
+   * See [HttpBodyHandler] constructor for more info on [defaultEncoding].
    */
-  static Future<HttpRequestBody> processRequest(HttpRequest request) {
-    return _HttpBodyHandler.processRequest(request);
+  static Future<HttpRequestBody> processRequest(
+      HttpRequest request,
+      {Encoding defaultEncoding: Encoding.UTF_8}) {
+    return _HttpBodyHandler.processRequest(request, defaultEncoding);
   }
 
   /**
    * Process and parse an incoming [HttpClientResponse].
+   *
+   * See [HttpBodyHandler] constructor for more info on [defaultEncoding].
    */
   static Future<HttpClientResponseBody> processResponse(
-      HttpClientResponse response) {
-    return _HttpBodyHandler.processResponse(response);
+      HttpClientResponse response,
+      {Encoding defaultEncoding: Encoding.UTF_8}) {
+    return _HttpBodyHandler.processResponse(response, defaultEncoding);
   }
 
   Stream<HttpRequestBody> bind(Stream<HttpRequest> stream) {
     return _transformer.bind(stream);
   }
 }
 
 
 /**
  * A HTTP content body produced by [HttpBodyHandler] for either [HttpRequest]
@@ skipping 89 matching lines @@
    * The [ContentType] of the uploaded file. For 'text/\*' and
    * 'application/json' the [data] field will a String.
    */
   ContentType contentType;
 
   /**
    * The content of the file. Either a [String] or a [List<int>].
    */
   dynamic content;
 }