Issue 15133004: Run with -use_browser_controller on the fyi bot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15133004: Run with -use_browser_controller on the fyi bot (Closed)

Created:
7 years, 7 months ago by ricow1

Modified:
7 years, 7 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Run with -use_browser_controller on the fyi bot R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=22678

Patch Set 1 #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	tools/bots/compiler.py	View		1 chunk	+4 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kustermann

lgtm https://codereview.chromium.org/15133004/diff/1/tools/bots/compiler.py File tools/bots/compiler.py (right): https://codereview.chromium.org/15133004/diff/1/tools/bots/compiler.py#newcode143 tools/bots/compiler.py:143: if os.environ.get('BUILDBOT_SCHEDULER') == "fyi-main": Why not using append() ...

7 years, 7 months ago (2013-05-14 13:24:10 UTC) #2

ricow1

7 years, 7 months ago (2013-05-14 13:28:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22678 (presubmit successful).

Expand Messages | Collapse Messages