Run with -use_browser_controller on the fyi bot

tools/bots/compiler.py

 #!/usr/bin/python
 
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """
 Dart2js buildbot steps
 
 Runs tests for the  dart2js compiler.
@@ skipping 121 matching lines @@
 
     # TODO(ricow/kustermann): Issue 7339
     if runtime == "safari":
       cmd.append('--nobatch')
 
     if user_test == 'yes':
       cmd.append('--progress=color')
     else:
       cmd.extend(['--progress=buildbot', '-v'])
 
+    # TODO(ricow): temporary hack to run on fyi with --use_browser_controller
+    if os.environ.get('BUILDBOT_SCHEDULER') == "fyi-main":

[kustermann, 2013/05/14 13:24:10]

Why not using append() as the others?

+      cmd.extend(['--use_browser_controller'])
+
     global IsFirstTestStepCall
     if IsFirstTestStepCall:
       IsFirstTestStepCall = False
     else:
       cmd.append('--append_logs')
 
     if flags:
       cmd.extend(flags)
     cmd.extend(targets)
 
@@ skipping 169 matching lines @@
   """
   with bot.BuildStep('Build SDK and d8'):
     args = [sys.executable, './tools/build.py', '--mode=' + build_info.mode,
             'dart2js_bot']
     print 'Build SDK and d8: %s' % (' '.join(args))
     bot.RunProcess(args)
 
 
 if __name__ == '__main__':
   bot.RunBot(GetBuildInfo, RunCompilerTests, build_step=BuildCompiler)