Issue 15128002: Address comments from https://codereview.chromium.org/14690009

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15128002: Address comments from https://codereview.chromium.org/14690009 (Closed)

Created:
7 years, 7 months ago by floitsch

Modified:
7 years, 7 months ago

Reviewers:
nweiz, Lasse Reichstein Nielsen

CC:
reviews_dartlang.org, nweiz

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -16 lines)			Patch
	M	pkg/scheduled_test/test/substitute_future_test.dart	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
	M	pkg/scheduled_test/test/value_future_test.dart	View	1	2 chunks	+11 lines, -12 lines	0 comments	Download

Total messages: 3 (0 generated)

floitsch

7 years, 7 months ago (2013-05-13 18:52:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r22642 (presubmit successful).