Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: pkg/scheduled_test/test/substitute_future_test.dart

Issue 15128002: Address comments from https://codereview.chromium.org/14690009 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add missing `completion`. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | pkg/scheduled_test/test/value_future_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library substitute_future_test; 5 library substitute_future_test;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'package:scheduled_test/src/substitute_future.dart'; 9 import 'package:scheduled_test/src/substitute_future.dart';
10 import 'package:unittest/unittest.dart'; 10 import 'package:unittest/unittest.dart';
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 completer1.completeError(1); 141 completer1.completeError(1);
142 completer2.completeError(2); 142 completer2.completeError(2);
143 completer3.completeError(3); 143 completer3.completeError(3);
144 }); 144 });
145 }); 145 });
146 146
147 test('substituting after a future has completed is an error', () { 147 test('substituting after a future has completed is an error', () {
148 var completer = new Completer(); 148 var completer = new Completer();
149 var future = new SubstituteFuture(completer.future); 149 var future = new SubstituteFuture(completer.future);
150 completer.complete('success'); 150 completer.complete('success');
151 future.then(expectAsync1((_) { 151 // The completer finishes asynchronously. So we have to wait for it to
152 expect(() => future.substitute(new Future.value()), 152 // be completed before we can substitute.
153 throwsStateError); 153 expect(future.then((_) => future.substitute(new Future.value())),
154 })); 154 throwsStateError);
155 }); 155 });
156 } 156 }
OLDNEW
« no previous file with comments | « no previous file | pkg/scheduled_test/test/value_future_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698