Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 151243003: Fixes for empty class and method bodies. (Closed)

Created:
6 years, 10 months ago by pquitslund
Modified:
6 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, kevmoo
Visibility:
Public.

Description

Fixes for empty class and method bodies. See Kevin's nits CL for more context: https://codereview.chromium.org/153623006/ R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=32378

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -11 lines) Patch
M pkg/analyzer/lib/src/services/formatter_impl.dart View 1 2 2 chunks +12 lines, -4 lines 0 comments Download
M pkg/analyzer/test/services/data/cu_tests.data View 1 2 1 chunk +13 lines, -1 line 0 comments Download
M pkg/analyzer/test/services/data/stmt_tests.data View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/analyzer/test/services/data/style_guide_tests.data View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/test/services/formatter_test.dart View 1 2 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pquitslund
6 years, 10 months ago (2014-02-06 19:12:24 UTC) #1
Brian Wilkerson
LGTM
6 years, 10 months ago (2014-02-06 19:25:37 UTC) #2
pquitslund
6 years, 10 months ago (2014-02-06 19:28:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r32378 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698