Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 15074006: Generating annotations from DOM triage list. (Closed)

Created:
7 years, 7 months ago by blois
Modified:
7 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Generating support annotations from DOM triage list. This is applying the results of the detailed API triage I did to the support annotations for DOM types. BUG= R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=23159

Patch Set 1 : #

Total comments: 35

Patch Set 2 : #

Total comments: 13

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2689 lines, -91 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 444 chunks +917 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 449 chunks +988 lines, -0 lines 0 comments Download
M sdk/lib/html/html_common/metadata.dart View 1 2 2 chunks +12 lines, -3 lines 0 comments Download
M sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart View 12 chunks +12 lines, -0 lines 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 14 chunks +17 lines, -0 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 157 chunks +162 lines, -0 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 157 chunks +163 lines, -0 lines 0 comments Download
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 1 35 chunks +89 lines, -0 lines 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 1 35 chunks +88 lines, -0 lines 0 comments Download
M sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 1 23 chunks +39 lines, -0 lines 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 1 23 chunks +39 lines, -0 lines 0 comments Download
M sdk/lib/web_sql/dart2js/web_sql_dart2js.dart View 1 11 chunks +26 lines, -0 lines 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 11 chunks +26 lines, -0 lines 0 comments Download
M tools/dom/dom.json View 1 18 chunks +34 lines, -66 lines 0 comments Download
M tools/dom/scripts/dartmetadata.py View 1 2 6 chunks +72 lines, -20 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 2 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
blois
This basically adds a ton of @Experimental annotations to various DOM APIs, and a few ...
7 years, 7 months ago (2013-05-10 18:32:47 UTC) #1
Emily Fortuna
https://codereview.chromium.org/15074006/diff/6018/sdk/lib/html/html_common/metadata.dart File sdk/lib/html/html_common/metadata.dart (left): https://codereview.chromium.org/15074006/diff/6018/sdk/lib/html/html_common/metadata.dart#oldcode57 sdk/lib/html/html_common/metadata.dart:57: /// Metadata that specifies that that member is editable ...
7 years, 7 months ago (2013-05-10 19:59:02 UTC) #2
blois
https://codereview.chromium.org/15074006/diff/6018/sdk/lib/html/html_common/metadata.dart File sdk/lib/html/html_common/metadata.dart (left): https://codereview.chromium.org/15074006/diff/6018/sdk/lib/html/html_common/metadata.dart#oldcode57 sdk/lib/html/html_common/metadata.dart:57: /// Metadata that specifies that that member is editable ...
7 years, 7 months ago (2013-05-10 20:17:01 UTC) #3
blois
Ping! Would like to get this in this week. On 2013/05/10 20:17:01, blois wrote: > ...
7 years, 7 months ago (2013-05-21 22:11:10 UTC) #4
Emily Fortuna
audio categorization looks good to me. the SVG I have some questions on. https://codereview.chromium.org/15074006/diff/6018/sdk/lib/html/html_common/metadata.dart File ...
7 years, 7 months ago (2013-05-22 01:09:08 UTC) #5
Jacob
https://codereview.chromium.org/15074006/diff/6018/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (left): https://codereview.chromium.org/15074006/diff/6018/sdk/lib/html/dartium/html_dartium.dart#oldcode2595 sdk/lib/html/dartium/html_dartium.dart:2595: bool isPropertyImplicit(String propertyName) native "CSSStyleDeclaration_isPropertyImplicit_Callback"; Make this deprecated not ...
7 years, 7 months ago (2013-05-22 01:34:07 UTC) #6
Jacob
https://codereview.chromium.org/15074006/diff/6018/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (left): https://codereview.chromium.org/15074006/diff/6018/sdk/lib/html/dartium/html_dartium.dart#oldcode2595 sdk/lib/html/dartium/html_dartium.dart:2595: bool isPropertyImplicit(String propertyName) native "CSSStyleDeclaration_isPropertyImplicit_Callback"; Make this deprecated not ...
7 years, 7 months ago (2013-05-22 01:34:07 UTC) #7
blois
Comments & fixups inline. Thanks for taking a look! On 2013/05/22 01:34:07, Jacob wrote: > ...
7 years, 7 months ago (2013-05-22 02:14:09 UTC) #8
blois
https://codereview.chromium.org/15074006/diff/6018/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (left): https://codereview.chromium.org/15074006/diff/6018/sdk/lib/html/dartium/html_dartium.dart#oldcode2595 sdk/lib/html/dartium/html_dartium.dart:2595: bool isPropertyImplicit(String propertyName) native "CSSStyleDeclaration_isPropertyImplicit_Callback"; On 2013/05/22 01:34:08, Jacob ...
7 years, 7 months ago (2013-05-22 02:14:16 UTC) #9
Andrei Mouravski
Needs more documentation and there's too much code copying in the python. https://codereview.chromium.org/15074006/diff/26001/sdk/lib/html/html_common/metadata.dart File sdk/lib/html/html_common/metadata.dart ...
7 years, 7 months ago (2013-05-22 10:07:00 UTC) #10
blois
https://codereview.chromium.org/15074006/diff/26001/sdk/lib/html/html_common/metadata.dart File sdk/lib/html/html_common/metadata.dart (right): https://codereview.chromium.org/15074006/diff/26001/sdk/lib/html/html_common/metadata.dart#newcode58 sdk/lib/html/html_common/metadata.dart:58: * Metadata that specifies that that member is editable ...
7 years, 7 months ago (2013-05-22 17:59:10 UTC) #11
blois
Further feedback? https://codereview.chromium.org/15074006/diff/26001/sdk/lib/web_sql/dartium/web_sql_dartium.dart File sdk/lib/web_sql/dartium/web_sql_dartium.dart (right): https://codereview.chromium.org/15074006/diff/26001/sdk/lib/web_sql/dartium/web_sql_dartium.dart#newcode271 sdk/lib/web_sql/dartium/web_sql_dartium.dart:271: @DocsEditable On 2013/05/22 10:07:00, Andrei Mouravski wrote: ...
7 years, 7 months ago (2013-05-23 21:34:09 UTC) #12
Andrei Mouravski
https://codereview.chromium.org/15074006/diff/26001/sdk/lib/web_sql/dartium/web_sql_dartium.dart File sdk/lib/web_sql/dartium/web_sql_dartium.dart (right): https://codereview.chromium.org/15074006/diff/26001/sdk/lib/web_sql/dartium/web_sql_dartium.dart#newcode271 sdk/lib/web_sql/dartium/web_sql_dartium.dart:271: @DocsEditable Actually, I was thinking more granular and have ...
7 years, 7 months ago (2013-05-23 21:52:12 UTC) #13
Jacob
lgtm
7 years, 7 months ago (2013-05-23 22:51:23 UTC) #14
blois
7 years, 7 months ago (2013-05-24 17:14:58 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 manually as r23159 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698