Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15074002: Report StaticTypeWarningCode.AMBIGUOUS_IMPORT when used as type annotation. (Closed)

Created:
7 years, 7 months ago by scheglov
Modified:
7 years, 7 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Report StaticTypeWarningCode.AMBIGUOUS_IMPORT when used as type annotation. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22542

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -46 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticTypeWarningCode.java View 1 chunk +16 lines, -0 lines 2 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/EnclosedScope.java View 2 chunks +3 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/LibraryImportScope.java View 4 chunks +64 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Scope.java View 2 chunks +4 lines, -2 lines 1 comment Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/scope/EnclosedScopeTest.java View 3 chunks +3 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/scope/LibraryImportScopeTest.java View 5 chunks +35 lines, -14 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/scope/LibraryScopeTest.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/scope/ScopeTest.java View 2 chunks +2 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java View 1 chunk +97 lines, -12 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java View 2 chunks +38 lines, -0 lines 0 comments Download
M tests/co19/co19-analyzer.status View 1 chunk +0 lines, -9 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
7 years, 7 months ago (2013-05-08 23:35:20 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/15074002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Scope.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Scope.java (right): https://codereview.chromium.org/15074002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Scope.java#newcode182 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Scope.java:182: * @param identifier TODO nit: missing comment
7 years, 7 months ago (2013-05-09 00:28:02 UTC) #2
jwren
LGTM, see comment https://codereview.chromium.org/15074002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticTypeWarningCode.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticTypeWarningCode.java (right): https://codereview.chromium.org/15074002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticTypeWarningCode.java#newcode29 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticTypeWarningCode.java:29: * <li>It is a static warning ...
7 years, 7 months ago (2013-05-09 01:39:29 UTC) #3
scheglov
Committed patchset #1 manually as r22542 (presubmit successful).
7 years, 7 months ago (2013-05-09 01:43:36 UTC) #4
scheglov
7 years, 7 months ago (2013-05-09 01:48:07 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/15074002/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticTypeWarningCode.java
(right):

https://codereview.chromium.org/15074002/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticTypeWarningCode.java:29:
* <li>It is a static warning if <i>N</i> is used as a type annotation.
On 2013/05/09 01:39:29, jwren wrote:
> If this is correct, then this is a static warning, not a static type warning. 
> Move this enum to StaticWarningCode

You are right.
I've missed that fact.
Will create new CL to fix this.

Powered by Google App Engine
This is Rietveld 408576698