Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2123)

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Scope.java

Issue 15074002: Report StaticTypeWarningCode.AMBIGUOUS_IMPORT when used as type annotation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Scope.java
diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Scope.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Scope.java
index ed7adb148821ba9495777142d48e832cb83893b4..f5ae4e909fb2c40712a350780df901cdea22ed10 100644
--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Scope.java
+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Scope.java
@@ -101,7 +101,7 @@ public abstract class Scope {
* @return the element with which the given identifier is associated
*/
public Element lookup(Identifier identifier, LibraryElement referencingLibrary) {
- return lookup(identifier.getName(), referencingLibrary);
+ return lookup(identifier, identifier.getName(), referencingLibrary);
}
/**
@@ -179,12 +179,14 @@ public abstract class Scope {
* Return the element with which the given name is associated, or {@code null} if the name is not
* defined within this scope.
*
+ * @param identifier TODO
Brian Wilkerson 2013/05/09 00:28:02 nit: missing comment
* @param name the name associated with the element to be returned
* @param referencingLibrary the library that contains the reference to the name, used to
* implement library-level privacy
* @return the element with which the given name is associated
*/
- protected abstract Element lookup(String name, LibraryElement referencingLibrary);
+ protected abstract Element lookup(Identifier identifier, String name,
+ LibraryElement referencingLibrary);
/**
* Return the name that will be used to look up the given element.

Powered by Google App Engine
This is Rietveld 408576698