Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 150693005: Fix ParameterMirror.hasDefaultValue/defaultValue in source mirrors. (Closed)

Created:
6 years, 10 months ago by Johnni Winther
Modified:
6 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix ParameterMirror.hasDefaultValue/defaultValue in source mirrors. BUG=http://dartbug.com/16535 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=32356 Committed: https://code.google.com/p/dart/source/detail?r=32409

Patch Set 1 #

Patch Set 2 : Fix handling of external parameters #

Unified diffs Side-by-side diffs Delta from patch set Stats (+640 lines, -23 lines) Patch
M sdk/lib/_internal/compiler/implementation/compile_time_constants.dart View 1 5 chunks +7 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 1 1 chunk +14 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart View 1 1 chunk +7 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_type_mirrors.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/source_mirrors.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 1 chunk +8 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 2 chunks +6 lines, -7 lines 0 comments Download
A tests/compiler/dart2js/mirrors/default_value_test.dart View 1 chunk +62 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/mirrors/mirrors_reader_test.dart View 1 1 chunk +122 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/mirrors/mirrors_test_helper.dart View 1 2 chunks +8 lines, -2 lines 0 comments Download
M tests/lib/lib.status View 1 2 chunks +4 lines, -0 lines 0 comments Download
A tests/lib/mirrors/mirrors_reader.dart View 1 1 chunk +257 lines, -0 lines 0 comments Download
A tests/lib/mirrors/mirrors_reader_test.dart View 1 1 chunk +49 lines, -0 lines 0 comments Download
A tests/lib/mirrors/mirrors_visitor.dart View 1 1 chunk +92 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Johnni Winther
6 years, 10 months ago (2014-02-06 08:38:43 UTC) #1
floitsch
LGTM.
6 years, 10 months ago (2014-02-06 12:51:45 UTC) #2
Johnni Winther
Committed patchset #1 manually as r32356 (presubmit successful).
6 years, 10 months ago (2014-02-06 13:29:05 UTC) #3
Johnni Winther
Reopened. PTAL
6 years, 10 months ago (2014-02-06 15:38:17 UTC) #4
floitsch
Still LGTM.
6 years, 10 months ago (2014-02-06 16:24:22 UTC) #5
Johnni Winther
6 years, 10 months ago (2014-02-07 08:04:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r32409 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698