sdk/lib/_internal/compiler/implementation/resolution/members.dart - Issue 150693005: Fix ParameterMirror.hasDefaultValue/defaultValue in source mirrors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 150693005: Fix ParameterMirror.hasDefaultValue/defaultValue in source mirrors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix handling of external parameters Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/mirrors/source_mirrors.dart ('k') | tests/compiler/dart2js/memory_compiler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/resolution/members.dart

diff --git a/sdk/lib/_internal/compiler/implementation/resolution/members.dart b/sdk/lib/_internal/compiler/implementation/resolution/members.dart

index af629c483ecf84a7f98210b320a8563f2f0e752a..2a951ecb53c1f4b76163c59cc2344b51ac183c76 100644

--- a/sdk/lib/_internal/compiler/implementation/resolution/members.dart

+++ b/sdk/lib/_internal/compiler/implementation/resolution/members.dart

@@ -326,8 +326,14 @@ class ResolverTask extends CompilerTask {

Link<Element> originParameters,

Link<Element> patchParameters) {

while (!originParameters.isEmpty) {

- Element originParameter = originParameters.head;

- Element patchParameter = patchParameters.head;

+ VariableElementX originParameter = originParameters.head;

+ VariableElementX patchParameter = patchParameters.head;

+ assert(invariant(originParameter, originParameter.origin == null));

+ assert(invariant(originParameter, originParameter.patch == null));

+ originParameter.patch = patchParameter;

+ assert(invariant(patchParameter, patchParameter.origin == null));

+ assert(invariant(patchParameter, patchParameter.patch == null));

+ patchParameter.origin = originParameter;

// Hack: Use unparser to test parameter equality. This only works because

// we are restricting patch uses and the approach cannot be used

// elsewhere.