Issue 15038008: Impelemnts some FPU arithmetic function for the MIPS simulator, assembler, disassembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15038008: Impelemnts some FPU arithmetic function for the MIPS simulator, assembler, disassembler. (Closed)

Created:
7 years, 7 months ago by zra

Modified:
7 years, 7 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Impelemnts some FPU arithmetic function for the MIPS simulator, assembler, disassembler. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=22818

Patch Set 2 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+213 lines, -11 lines)			Patch
M	runtime/vm/assembler_mips.h	View		4 chunks	+33 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_mips_test.cc	View		2 chunks	+101 lines, -0 lines	0 comments	Download
M	runtime/vm/constants_mips.h	View	1	2 chunks	+19 lines, -11 lines	0 comments	Download
M	runtime/vm/disassembler_mips.cc	View		2 chunks	+20 lines, -0 lines	0 comments	Download
M	runtime/vm/simulator_mips.cc	View		2 chunks	+40 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/15038008/diff/1/runtime/vm/constants_mips.h File runtime/vm/constants_mips.h (right): https://codereview.chromium.org/15038008/diff/1/runtime/vm/constants_mips.h#newcode387 runtime/vm/constants_mips.h:387: COP1_CVT_D = 0x21, // 100001 You should remove ...

7 years, 7 months ago (2013-05-16 21:00:32 UTC) #2

zra

Thanks! https://codereview.chromium.org/15038008/diff/1/runtime/vm/constants_mips.h File runtime/vm/constants_mips.h (right): https://codereview.chromium.org/15038008/diff/1/runtime/vm/constants_mips.h#newcode387 runtime/vm/constants_mips.h:387: COP1_CVT_D = 0x21, // 100001 On 2013/05/16 21:00:33, ...

7 years, 7 months ago (2013-05-16 21:15:19 UTC) #3

zra

7 years, 7 months ago (2013-05-16 21:18:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r22818 (presubmit successful).

Expand Messages | Collapse Messages

Issue 15038008: Impelemnts some FPU arithmetic function for the MIPS simulator, assembler, disassembler. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages