dart:io | Add FileSystemEntity.stat() and FileStat class.

dart:io | Add FileSystemEntity.stat() and FileStat class.

BUG=
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22685

[Bill Hesse, 2013-05-14 11:34:12]

https://codereview.chromium.org/15018011/diff/2001/runtime/bin/dartutils.h
File runtime/bin/dartutils.h (right):

https://codereview.chromium.org/15018011/diff/2001/runtime/bin/dartutils.h#ne...
runtime/bin/dartutils.h:212: static const int kArgumentError = 1;
We could make all but kSuccess private, but kSuccess needs to be public unless
we provide a "Wrapping" function in the CObject API and an unwrap on the Dart
side.

[Søren Gjesse, 2013-05-14 13:50:36]

lgtm, with comments

https://codereview.chromium.org/15018011/diff/9001/runtime/bin/dartutils.h
File runtime/bin/dartutils.h (right):

https://codereview.chromium.org/15018011/diff/9001/runtime/bin/dartutils.h#ne...
runtime/bin/dartutils.h:210: // These match the constants in
sdk/lib/io/common.dart.
These constants should be moved. They are not part of the serialization, but the
RPC protocol currently used between Dart code and the native threads.

https://codereview.chromium.org/15018011/diff/9001/runtime/bin/dartutils.h#ne...
runtime/bin/dartutils.h:262: static Dart_CObject* NewString(const char* str);
I don't think this comment belongs here. It is specific to the current RPC
protocol used between the Dart code and the native port.

https://codereview.chromium.org/15018011/diff/9001/runtime/bin/file.cc
File runtime/bin/file.cc (right):

https://codereview.chromium.org/15018011/diff/9001/runtime/bin/file.cc#newcod...
runtime/bin/file.cc:609: "Non-string argument to FileSystemEntity.type");
.type -> .stat

https://codereview.chromium.org/15018011/diff/9001/sdk/lib/io/file_system_ent...
File sdk/lib/io/file_system_entity.dart (right):

https://codereview.chromium.org/15018011/diff/9001/sdk/lib/io/file_system_ent...
sdk/lib/io/file_system_entity.dart:114: var result = [];
These flags does not match the content of the man page for stat.

     S_ISUID    0004000   set UID bit
     S_ISGID    0002000   set-group-ID bit (see below)
     S_ISVTX    0001000   sticky bit (see below)
     S_IRWXU    00700     mask for file owner permissions
     S_IRUSR    00400     owner has read permission
     S_IWUSR    00200     owner has write permission
     S_IXUSR    00100     owner has execute permission
     S_IRWXG    00070     mask for group permissions
     S_IRGRP    00040     group has read permission
     S_IWGRP    00020     group has write permission
     S_IXGRP    00010     group has execute permission
     S_IRWXO    00007     mask for permissions for others (not in group)
     S_IROTH    00004     others have read permission
     S_IWOTH    00002     others have write permission
     S_IXOTH    00001     others have execute permission

https://codereview.chromium.org/15018011/diff/9001/sdk/lib/io/file_system_ent...
sdk/lib/io/file_system_entity.dart:114: var result = [];
Want does Windows report for these mode flags?

[Bill Hesse, 2013-05-14 16:26:28]

Committed patchset #4 manually as r22685 (presubmit successful).

[Bill Hesse, 2013-05-14 16:33:58]

https://codereview.chromium.org/15018011/diff/9001/runtime/bin/dartutils.h
File runtime/bin/dartutils.h (right):

https://codereview.chromium.org/15018011/diff/9001/runtime/bin/dartutils.h#ne...
runtime/bin/dartutils.h:210: // These match the constants in
sdk/lib/io/common.dart.
I would do this, but I don't know where you think they should be moved to.  The
relevant file would seem to be native_service.h, but there is not much there
about this.
The code that uses these constants is in the implementation of the CObject class
in dartutils.cc, so the RPC protocol currently used between Dart and native
ports seems to be pretty well encapsulated in CObject and related classes, which
is in dartutils.

So I don't know where you want to move this, so I can't do it.


I could move them further down in the class, to where FileClosedError is
declared, but consts and enums are supposed to be at the top of the class.

On 2013/05/14 13:50:36, Søren Gjesse wrote:
> These constants should be moved. They are not part of the serialization, but
the
> RPC protocol currently used between Dart code and the native threads.

https://codereview.chromium.org/15018011/diff/9001/runtime/bin/dartutils.h#ne...
runtime/bin/dartutils.h:262: static Dart_CObject* NewString(const char* str);
On 2013/05/14 13:50:36, Søren Gjesse wrote:
> I don't think this comment belongs here. It is specific to the current RPC
> protocol used between the Dart code and the native port.

Removed.  But the RPC protocol is exactly the function NewOSError,
FileClosedError, and IllegalArgumentError, just below, isn't it?

https://codereview.chromium.org/15018011/diff/9001/runtime/bin/file.cc
File runtime/bin/file.cc (right):

https://codereview.chromium.org/15018011/diff/9001/runtime/bin/file.cc#newcod...
runtime/bin/file.cc:609: "Non-string argument to FileSystemEntity.type");
On 2013/05/14 13:50:36, Søren Gjesse wrote:
> .type -> .stat

Done.

https://codereview.chromium.org/15018011/diff/9001/sdk/lib/io/file_system_ent...
File sdk/lib/io/file_system_entity.dart (right):

https://codereview.chromium.org/15018011/diff/9001/sdk/lib/io/file_system_ent...
sdk/lib/io/file_system_entity.dart:114: var result = [];
On 2013/05/14 13:50:36, Søren Gjesse wrote:
> Want does Windows report for these mode flags?

Windows creates reasonable values for them, based on what the Windows
permissions on the file are, according to all my tests.

https://codereview.chromium.org/15018011/diff/9001/sdk/lib/io/file_system_ent...
sdk/lib/io/file_system_entity.dart:114: var result = [];
On 2013/05/14 13:50:36, Søren Gjesse wrote:
> These flags does not match the content of the man page for stat.
> 
>      S_ISUID    0004000   set UID bit
>      S_ISGID    0002000   set-group-ID bit (see below)
>      S_ISVTX    0001000   sticky bit (see below)
>      S_IRWXU    00700     mask for file owner permissions
>      S_IRUSR    00400     owner has read permission
>      S_IWUSR    00200     owner has write permission
>      S_IXUSR    00100     owner has execute permission
>      S_IRWXG    00070     mask for group permissions
>      S_IRGRP    00040     group has read permission
>      S_IWGRP    00020     group has write permission
>      S_IXGRP    00010     group has execute permission
>      S_IRWXO    00007     mask for permissions for others (not in group)
>      S_IROTH    00004     others have read permission
>      S_IWOTH    00002     others have write permission
>      S_IXOTH    00001     others have execute permission

Those numbers are in octal, and mine are in hex or decimal.

[Søren Gjesse, 2013-05-15 14:06:35]

lgtm

https://codereview.chromium.org/15018011/diff/9001/runtime/bin/dartutils.h
File runtime/bin/dartutils.h (right):

https://codereview.chromium.org/15018011/diff/9001/runtime/bin/dartutils.h#ne...
runtime/bin/dartutils.h:210: // These match the constants in
sdk/lib/io/common.dart.
On 2013/05/14 16:33:58, Bill Hesse wrote:
> I would do this, but I don't know where you think they should be moved to. 
The
> relevant file would seem to be native_service.h, but there is not much there
> about this.
> The code that uses these constants is in the implementation of the CObject
class
> in dartutils.cc, so the RPC protocol currently used between Dart and native
> ports seems to be pretty well encapsulated in CObject and related classes,
which
> is in dartutils.
> 
> So I don't know where you want to move this, so I can't do it.
> 
> 
> I could move them further down in the class, to where FileClosedError is
> declared, but consts and enums are supposed to be at the top of the class.
> 
> On 2013/05/14 13:50:36, Søren Gjesse wrote:
> > These constants should be moved. They are not part of the serialization, but
> the
> > RPC protocol currently used between Dart code and the native threads.
> 

Let's create a new class NativePortRPC with these constants. and move then
methods IllegalArgumentError, FileClosedError and NewOSError (x2) from CObject
as well. It can be here in dartutils.h.

https://codereview.chromium.org/15018011/diff/9001/runtime/bin/dartutils.h#ne...
runtime/bin/dartutils.h:262: static Dart_CObject* NewString(const char* str);
On 2013/05/14 16:33:58, Bill Hesse wrote:
> On 2013/05/14 13:50:36, Søren Gjesse wrote:
> > I don't think this comment belongs here. It is specific to the current RPC
> > protocol used between the Dart code and the native port.
> 
> Removed.  But the RPC protocol is exactly the function NewOSError,
> FileClosedError, and IllegalArgumentError, just below, isn't it?

That's right, see comment above.

https://codereview.chromium.org/15018011/diff/9001/sdk/lib/io/file_system_ent...
File sdk/lib/io/file_system_entity.dart (right):

https://codereview.chromium.org/15018011/diff/9001/sdk/lib/io/file_system_ent...
sdk/lib/io/file_system_entity.dart:114: var result = [];
On 2013/05/14 16:33:58, Bill Hesse wrote:
> On 2013/05/14 13:50:36, Søren Gjesse wrote:
> > These flags does not match the content of the man page for stat.
> > 
> >      S_ISUID    0004000   set UID bit
> >      S_ISGID    0002000   set-group-ID bit (see below)
> >      S_ISVTX    0001000   sticky bit (see below)
> >      S_IRWXU    00700     mask for file owner permissions
> >      S_IRUSR    00400     owner has read permission
> >      S_IWUSR    00200     owner has write permission
> >      S_IXUSR    00100     owner has execute permission
> >      S_IRWXG    00070     mask for group permissions
> >      S_IRGRP    00040     group has read permission
> >      S_IWGRP    00020     group has write permission
> >      S_IXGRP    00010     group has execute permission
> >      S_IRWXO    00007     mask for permissions for others (not in group)
> >      S_IROTH    00004     others have read permission
> >      S_IWOTH    00002     others have write permission
> >      S_IXOTH    00001     others have execute permission
> 
> Those numbers are in octal, and mine are in hex or decimal.

My bad, sorry for the confusion.