dart:io | Add FileSystemEntity.stat() and FileStat class.

runtime/bin/dartutils.h

Index: runtime/bin/dartutils.h
diff --git a/runtime/bin/dartutils.h b/runtime/bin/dartutils.h
index a9b86f717a86186880706c82275cf5af67161afe..051086b74be8969ff49ae1f6400fef62d0c65947 100644
--- a/runtime/bin/dartutils.h
+++ b/runtime/bin/dartutils.h
@@ -207,6 +207,12 @@ class DartUtils {
 
 class CObject {
  public:
+  // These match the constants in sdk/lib/io/common.dart.

[Søren Gjesse, 2013/05/14 13:50:36]

These constants should be moved. They are not part of the serialization, but the
RPC protocol currently used between Dart code and the native threads.

[Bill Hesse, 2013/05/14 16:33:58]

I would do this, but I don't know where you think they should be moved to.  The
relevant file would seem to be native_service.h, but there is not much there
about this.
The code that uses these constants is in the implementation of the CObject class
in dartutils.cc, so the RPC protocol currently used between Dart and native
ports seems to be pretty well encapsulated in CObject and related classes, which
is in dartutils.

So I don't know where you want to move this, so I can't do it.


I could move them further down in the class, to where FileClosedError is
declared, but consts and enums are supposed to be at the top of the class.

On 2013/05/14 13:50:36, Søren Gjesse wrote:

[Søren Gjesse, 2013/05/15 14:06:35]

Let's create a new class NativePortRPC with these constants. and move then
methods IllegalArgumentError, FileClosedError and NewOSError (x2) from CObject
as well. It can be here in dartutils.h.

+  static const int kSuccess = 0;
+  static const int kArgumentError = 1;
+  static const int kOSError = 2;
+  static const int kFileClosedError = 3;
+
   explicit CObject(Dart_CObject *cobject) : cobject_(cobject) {}
   Dart_CObject::Type type() { return cobject_->type; }
   Dart_CObject::TypedDataType byte_array_type() {
@@ -254,6 +260,9 @@ class CObject {
   static Dart_CObject* NewDouble(double value);
   static Dart_CObject* NewString(int length);
   static Dart_CObject* NewString(const char* str);

[Søren Gjesse, 2013/05/14 13:50:36]

I don't think this comment belongs here. It is specific to the current RPC
protocol used between the Dart code and the native port.

[Bill Hesse, 2013/05/14 16:33:58]

Removed.  But the RPC protocol is exactly the function NewOSError,
FileClosedError, and IllegalArgumentError, just below, isn't it?

[Søren Gjesse, 2013/05/15 14:06:35]

That's right, see comment above.

+  // A CObject array cannot be returned as the result, since errors are
+  // encoded as arrays starting with a nonzero first element.  It must be
+  // wrapped in an array starting with kSuccess, and unwrapped by the receiver.
   static Dart_CObject* NewArray(int length);
   static Dart_CObject* NewUint8Array(int length);
   static Dart_CObject* NewExternalUint8Array(