Issue 15001028: Fix type warnings in API and helpers.

Issue 15001028: Fix type warnings in API and helpers. (Closed)

Created:
7 years, 7 months ago by Johnni Winther

Modified:
7 years, 7 months ago

Reviewers:
ahe, Søren Gjesse, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix type warnings in API and helpers. BUG= R=ngeoffray@google.com, sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=22736

Patch Set 2 : Updated cf. comments. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -21 lines)			Patch
M	sdk/lib/_collection_dev/arrays.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/core_patch.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/interceptors.dart	View		3 chunks	+18 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_helper.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_number.dart	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	sdk/lib/io/http_headers.dart	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/io/http_impl.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/15001028/diff/1/sdk/lib/_internal/compiler/implementation/lib/js_number.dart File sdk/lib/_internal/compiler/implementation/lib/js_number.dart (right): https://codereview.chromium.org/15001028/diff/1/sdk/lib/_internal/compiler/implementation/lib/js_number.dart#newcode97 sdk/lib/_internal/compiler/implementation/lib/js_number.dart:97: toDouble() => this; Please add a comment that ...

7 years, 7 months ago (2013-05-15 11:57:07 UTC) #2

Søren Gjesse

lgtm https://codereview.chromium.org/15001028/diff/1/sdk/lib/io/http_headers.dart File sdk/lib/io/http_headers.dart (right): https://codereview.chromium.org/15001028/diff/1/sdk/lib/io/http_headers.dart#newcode210 sdk/lib/io/http_headers.dart:210: void _add(String name, var value) { Can't you ...

7 years, 7 months ago (2013-05-15 12:55:03 UTC) #3

Johnni Winther

Committed patchset #2 manually as r22736 (presubmit successful).

7 years, 7 months ago (2013-05-15 13:42:11 UTC) #4

Johnni Winther

7 years, 7 months ago (2013-05-17 12:06:42 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/15001028/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/lib/js_number.dart (right):

https://codereview.chromium.org/15001028/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/lib/js_number.dart:97: toDouble() =>
this;
On 2013/05/15 11:57:07, ngeoffray wrote:
> Please add a comment that this is deliberate.

Done.

https://codereview.chromium.org/15001028/diff/1/sdk/lib/io/http_headers.dart
File sdk/lib/io/http_headers.dart (right):

https://codereview.chromium.org/15001028/diff/1/sdk/lib/io/http_headers.dart#...
sdk/lib/io/http_headers.dart:210: void _add(String name, var value) {
On 2013/05/15 12:55:03, Søren Gjesse wrote:
> Can't you remove var here? In other places in dart:io where we have dynamic
> arguments we just leave the type altogether.

Done.

Expand Messages | Collapse Messages