Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

Issue 15001028: Fix type warnings in API and helpers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
diff --git a/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart b/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
index 45e9ef81c5b028d95dcd3ded5931791bfeb7f926..9e6765e3d0e30bab4dbc8109222330a32be51c52 100644
--- a/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
+++ b/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
@@ -539,14 +539,14 @@ class Primitives {
// arguments order.
if (namedArguments != null && !namedArguments.isEmpty) {
// Call new List.from to make sure we get a JavaScript array.
- List<String> listOfNamedArguments =
- new List<String>.from(namedArguments.keys);
+ List<Symbol> listOfNamedArguments =
+ new List<Symbol>.from(namedArguments.keys);
argumentCount += namedArguments.length;
// We're sorting on strings, and the behavior is the same between
// Dart string sort and JS string sort. To avoid needing the Dart
// sort implementation, we use the JavaScript one instead.
JS('void', '#.sort()', listOfNamedArguments);
- listOfNamedArguments.forEach((String name) {
+ listOfNamedArguments.forEach((Symbol name) {
buffer.write('\$$name');
arguments.add(namedArguments[name]);
});

Powered by Google App Engine
This is Rietveld 408576698