Issue 14993002: Fix error_group_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14993002: Fix error_group_test. (Closed)

Created:
7 years, 7 months ago by floitsch

Modified:
7 years, 6 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix error_group_test. Committed: https://code.google.com/p/dart/source/detail?r=22425

Patch Set 1 #

Total comments: 2

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	sdk/lib/_internal/pub/test/error_group_test.dart	View		1 chunk	+6 lines, -4 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

Committed patchset #1 manually as r22425 (presubmit successful).

7 years, 7 months ago (2013-05-06 16:30:24 UTC) #2

nweiz

https://codereview.chromium.org/14993002/diff/1/sdk/lib/_internal/pub/test/error_group_test.dart File sdk/lib/_internal/pub/test/error_group_test.dart (right): https://codereview.chromium.org/14993002/diff/1/sdk/lib/_internal/pub/test/error_group_test.dart#newcode66 sdk/lib/_internal/pub/test/error_group_test.dart:66: completer.future.then(expectAsync1((_) { As in the other CL, convert these ...

7 years, 7 months ago (2013-05-07 00:18:11 UTC) #3

floitsch

7 years, 6 months ago (2013-06-13 15:52:35 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/14993002/diff/1/sdk/lib/_internal/pub/test/er...
File sdk/lib/_internal/pub/test/error_group_test.dart (right):

https://codereview.chromium.org/14993002/diff/1/sdk/lib/_internal/pub/test/er...
sdk/lib/_internal/pub/test/error_group_test.dart:66:
completer.future.then(expectAsync1((_) {
On 2013/05/07 00:18:11, nweiz wrote:
> As in the other CL, convert these to "expect(completer.future.then((_) =>
...),
> throwsStateError)".
done in https://codereview.chromium.org/16950010

Expand Messages | Collapse Messages