Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: sdk/lib/_internal/pub/test/error_group_test.dart

Issue 14993002: Fix error_group_test. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/test/error_group_test.dart
diff --git a/sdk/lib/_internal/pub/test/error_group_test.dart b/sdk/lib/_internal/pub/test/error_group_test.dart
index db952c872730a8f708bbf80e2eb9592fc1d7b0bc..ff2f699dbacd75574e7b677a65c1bd600896746b 100644
--- a/sdk/lib/_internal/pub/test/error_group_test.dart
+++ b/sdk/lib/_internal/pub/test/error_group_test.dart
@@ -63,10 +63,12 @@ main() {
"been called", () {
completer.complete('value');
- expect(() => errorGroup.registerFuture(new Future.value()),
- throwsStateError);
- expect(() => errorGroup.registerStream(new StreamController().stream),
- throwsStateError);
+ completer.future.then(expectAsync1((_) {
nweiz 2013/05/07 00:18:11 As in the other CL, convert these to "expect(compl
floitsch 2013/06/13 15:52:35 done in https://codereview.chromium.org/16950010
+ expect(() => errorGroup.registerFuture(new Future.value()),
+ throwsStateError);
+ expect(() => errorGroup.registerStream(new StreamController().stream),
+ throwsStateError);
+ }));
});
test('should pass through an exception from the future if it has a '
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698