Issue 149913002: Max line length test fix (dartbug.com/16405).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149913002: Max line length test fix (dartbug.com/16405). (Closed)

Created:
6 years, 10 months ago by pquitslund

Modified:
6 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Max line length test fix (dartbug.com/16405). The rub: two off by ones! --- Proof that two wrongs don't make a right! :) R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=32166

Patch Set 1 #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -2 lines)			Patch
	M	pkg/analyzer/lib/src/services/writer.dart	View		2 chunks	+6 lines, -2 lines	1 comment	Download
	M	pkg/analyzer/test/services/data/cu_tests.data	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/149913002/diff/1/pkg/analyzer/lib/src/services/writer.dart File pkg/analyzer/lib/src/services/writer.dart (right): https://codereview.chromium.org/149913002/diff/1/pkg/analyzer/lib/src/services/writer.dart#newcode267 pkg/analyzer/lib/src/services/writer.dart:267: str.endsWith('\n') ? str.length - 1 : str.length; Do ...

6 years, 10 months ago (2014-01-30 00:51:19 UTC) #2

pquitslund

6 years, 10 months ago (2014-01-30 18:35:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r32166 (presubmit successful).

Expand Messages | Collapse Messages