Issue 149643007: Small cleanup: move all library private key code to Library class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149643007: Small cleanup: move all library private key code to Library class (Closed)

Created:
6 years, 10 months ago by hausner

Modified:
6 years, 10 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Small cleanup: move all library private key code to Library class R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=32522

Patch Set 1 #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -40 lines)			Patch
M	runtime/vm/object.h	View	3 chunks	+10 lines, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	8 chunks	+29 lines, -15 lines	1 comment	Download
M	runtime/vm/scanner.h	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	runtime/vm/scanner.cc	View	2 chunks	+1 line, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

https://codereview.chromium.org/149643007/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/149643007/diff/1/runtime/vm/object.cc#newcode7851 runtime/vm/object.cc:7851: ASSERT(!Field::IsGetterName(name) && !Field::IsSetterName(name)); Unrelated but on purpose.

6 years, 10 months ago (2014-02-10 21:07:34 UTC) #1

hausner

6 years, 10 months ago (2014-02-10 22:28:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r32522 (presubmit successful).

Expand Messages | Collapse Messages