Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: runtime/vm/object.h

Issue 149643007: Small cleanup: move all library private key code to Library class (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | runtime/vm/object.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
===================================================================
--- runtime/vm/object.h (revision 32509)
+++ runtime/vm/object.h (working copy)
@@ -2588,7 +2588,6 @@
static RawLibrary* LookupLibrary(const String& url);
static RawLibrary* GetLibrary(intptr_t index);
- static bool IsKeyUsed(intptr_t key);
static void InitCoreLibrary(Isolate* isolate);
static void InitNativeWrappersLibrary(Isolate* isolate);
@@ -2623,6 +2622,13 @@
const char* class_name,
const char* function_name);
+ // Character used to indicate a private identifier.
+ static const char kPrivateIdentifierStart = '_';
+
+ // Character used to separate private identifiers from
+ // the library-specific key.
+ static const char kPrivateKeySeparator = '@';
+
private:
static const int kInitialImportsCapacity = 4;
static const int kImportsCapacityIncrement = 8;
@@ -2654,6 +2660,9 @@
bool import_core_lib);
RawObject* LookupEntry(const String& name, intptr_t *index) const;
+ static bool IsKeyUsed(intptr_t key);
+ void AllocatePrivateKey() const;
+
RawString* MakeMetadataName(const Object& obj) const;
RawField* GetMetadataField(const String& metaname) const;
void AddMetadata(const Class& cls,
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | runtime/vm/object.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698