Actually end a ZLib stream with a Z_FINISH marker.

Actually end a ZLib stream with a Z_FINISH marker.

BUG=
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22830

[kustermann, 2013-05-16 10:10:08]

https://codereview.chromium.org/14962006/diff/1/tests/standalone/io/zlib_test...
File tests/standalone/io/zlib_test.dart (right):

https://codereview.chromium.org/14962006/diff/1/tests/standalone/io/zlib_test...
tests/standalone/io/zlib_test.dart:28: 0, 46]);
I don't know why your tests didn't catch this issue. These numbers here are
totally opaque to me.

But to make sure we're doing the right thing, I think we should test
- gzipping data with /bin/gzip and trying to unzip with builtin code
- gzipping with builtin code and trying to unzip with /bin/gunzip
- gzipping with builtin code and trying to unzip with builtin code

[Søren Gjesse, 2013-05-16 11:46:18]

lgtm

[Anders Johnsen, 2013-05-17 06:28:39]

Committed patchset #1 manually as r22830 (presubmit successful).

[Anders Johnsen, 2013-06-11 12:15:15]

https://codereview.chromium.org/14962006/diff/1/tests/standalone/io/zlib_test...
File tests/standalone/io/zlib_test.dart (right):

https://codereview.chromium.org/14962006/diff/1/tests/standalone/io/zlib_test...
tests/standalone/io/zlib_test.dart:28: 0, 46]);
On 2013/05/16 10:10:08, kustermann wrote:
> I don't know why your tests didn't catch this issue. These numbers here are
> totally opaque to me.
> 
> But to make sure we're doing the right thing, I think we should test
> - gzipping data with /bin/gzip and trying to unzip with builtin code
> - gzipping with builtin code and trying to unzip with /bin/gunzip
> - gzipping with builtin code and trying to unzip with builtin code

The new test is testing that we actually do get a finish chunk. I can't do the
other tests, as they are not platform independent. We do the last test already.

[kustermann, 2013-06-11 12:18:13]

On 2013/06/11 12:15:15, Anders Johnsen wrote:
>
https://codereview.chromium.org/14962006/diff/1/tests/standalone/io/zlib_test...
> File tests/standalone/io/zlib_test.dart (right):
> 
>
https://codereview.chromium.org/14962006/diff/1/tests/standalone/io/zlib_test...
> tests/standalone/io/zlib_test.dart:28: 0, 46]);
> On 2013/05/16 10:10:08, kustermann wrote:
> > I don't know why your tests didn't catch this issue. These numbers here are
> > totally opaque to me.
> > 
> > But to make sure we're doing the right thing, I think we should test
> > - gzipping data with /bin/gzip and trying to unzip with builtin code
> > - gzipping with builtin code and trying to unzip with /bin/gunzip
> > - gzipping with builtin code and trying to unzip with builtin code
> 
> The new test is testing that we actually do get a finish chunk. I can't do the
> other tests, as they are not platform independent. We do the last test
already.

It's up to you. But you could still test these things on linux and skip the test
on windows/mac.