pkg/unittest: more lock-down, cleanup

pkg/unittest: more lock-down, cleanup

TestCase: cannot set 'enabled' directly. Use enable/disableTest top-level method
TestCase: pass, fail, error are now private

Tests for protectAsyncN
Moved private helper classes into their own files
html_enhanced_config: fixed usage of deprecated query apis

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32255

[Siggi Cherem (dart-lang), 2014-02-03 18:09:46]

lgtm

https://codereview.chromium.org/149573006/diff/1/pkg/unittest/lib/html_enhanc...
File pkg/unittest/lib/html_enhanced_config.dart (right):

https://codereview.chromium.org/149573006/diff/1/pkg/unittest/lib/html_enhanc...
pkg/unittest/lib/html_enhanced_config.dart:210: var grp = (safeGroup == '') ?
null : te.querySelector('#${safeGroup}');
80

https://codereview.chromium.org/149573006/diff/1/pkg/unittest/lib/src/spread_...
File pkg/unittest/lib/src/spread_args_helper.dart (right):

https://codereview.chromium.org/149573006/diff/1/pkg/unittest/lib/src/spread_...
pkg/unittest/lib/src/spread_args_helper.dart:6: class _SpreadArgsHelper {
wonder if we should rename this. It started with just support for multiple
arguments, but now it's actually mainly the logic to deal with tracking callback
expectations.

https://codereview.chromium.org/149573006/diff/1/pkg/unittest/lib/unittest.dart
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/149573006/diff/1/pkg/unittest/lib/unittest.da...
pkg/unittest/lib/unittest.dart:151: part 'src/spread_args_helper.dart';
I was hoping we can start splitting this into multiple libraries, rather than
multiple parts.

https://codereview.chromium.org/149573006/diff/1/pkg/unittest/lib/unittest.da...
pkg/unittest/lib/unittest.dart:322: // TODO(sigmund): deprecate this API when
issue 2706 is fixed.
BTW - now that 2706 is fixed, we can fix up a bit this API. 

I tried once using some generic 'call' method on a class, but that was not
really working. However, in another CL I just noticed a trick we can probably
use to merge expectAsync0/1/2 in a single expectAsync.

Here is the trick:

typedef _Func2(a, b);
typedef _Func1(a);
typedef _Func0();

Function expectAsync(callback, ...) {
  var helper = new _SpreadArgsHelper(...);
  if (callback is _Func2) return helper.invoke2;
  if (callback is _Func1) return helper.invoke1;
  if (callback is _Func0) return helper.invoke0;
}

We could even add more options (like definitions that accept optional arguments
and everything!)

[kevmoo, 2014-02-03 18:22:56]

https://codereview.chromium.org/149573006/diff/1/pkg/unittest/lib/html_enhanc...
File pkg/unittest/lib/html_enhanced_config.dart (right):

https://codereview.chromium.org/149573006/diff/1/pkg/unittest/lib/html_enhanc...
pkg/unittest/lib/html_enhanced_config.dart:210: var grp = (safeGroup == '') ?
null : te.querySelector('#${safeGroup}');
On 2014/02/03 18:09:46, Siggi Cherem (dart-lang) wrote:
> 80

Done.

https://codereview.chromium.org/149573006/diff/1/pkg/unittest/lib/src/spread_...
File pkg/unittest/lib/src/spread_args_helper.dart (right):

https://codereview.chromium.org/149573006/diff/1/pkg/unittest/lib/src/spread_...
pkg/unittest/lib/src/spread_args_helper.dart:6: class _SpreadArgsHelper {
On 2014/02/03 18:09:46, Siggi Cherem (dart-lang) wrote:
> wonder if we should rename this. It started with just support for multiple
> arguments, but now it's actually mainly the logic to deal with tracking
callback
> expectations. 

Sure. But in another CL. I've already spread out the changes here to more than a
few things.

https://codereview.chromium.org/149573006/diff/1/pkg/unittest/lib/unittest.dart
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/149573006/diff/1/pkg/unittest/lib/unittest.da...
pkg/unittest/lib/unittest.dart:151: part 'src/spread_args_helper.dart';
On 2014/02/03 18:09:46, Siggi Cherem (dart-lang) wrote:
> I was hoping we can start splitting this into multiple libraries, rather than
> multiple parts. 

Absolutely, but in another CL. :-)

https://codereview.chromium.org/149573006/diff/1/pkg/unittest/lib/unittest.da...
pkg/unittest/lib/unittest.dart:322: // TODO(sigmund): deprecate this API when
issue 2706 is fixed.
On 2014/02/03 18:09:46, Siggi Cherem (dart-lang) wrote:
> BTW - now that 2706 is fixed, we can fix up a bit this API. 
> 
> I tried once using some generic 'call' method on a class, but that was not
> really working. However, in another CL I just noticed a trick we can probably
> use to merge expectAsync0/1/2 in a single expectAsync.
> 
> Here is the trick:
> 
> typedef _Func2(a, b);
> typedef _Func1(a);
> typedef _Func0();
> 
> Function expectAsync(callback, ...) {
>   var helper = new _SpreadArgsHelper(...);
>   if (callback is _Func2) return helper.invoke2;
>   if (callback is _Func1) return helper.invoke1;
>   if (callback is _Func0) return helper.invoke0;
> }
> 
> We could even add more options (like definitions that accept optional
arguments
> and everything!)

I tried this awhile ago and failed because of checked mode not liking classes
with call method in some contexts. Certainly a place to investigate. ... in
another CL :-)

[kevmoo, 2014-02-03 18:24:24]

Committed patchset #4 manually as r32255 (presubmit successful).

[Siggi Cherem (dart-lang), 2014-02-03 22:54:39]

https://codereview.chromium.org/149573006/diff/1/pkg/unittest/lib/unittest.dart
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/149573006/diff/1/pkg/unittest/lib/unittest.da...
pkg/unittest/lib/unittest.dart:322: // TODO(sigmund): deprecate this API when
issue 2706 is fixed.
On 2014/02/03 18:22:57, kevmoo wrote:
> On 2014/02/03 18:09:46, Siggi Cherem (dart-lang) wrote:
> > BTW - now that 2706 is fixed, we can fix up a bit this API. 
> > 
> > I tried once using some generic 'call' method on a class, but that was not
> > really working. However, in another CL I just noticed a trick we can
probably
> > use to merge expectAsync0/1/2 in a single expectAsync.
> > 
> > Here is the trick:
> > 
> > typedef _Func2(a, b);
> > typedef _Func1(a);
> > typedef _Func0();
> > 
> > Function expectAsync(callback, ...) {
> >   var helper = new _SpreadArgsHelper(...);
> >   if (callback is _Func2) return helper.invoke2;
> >   if (callback is _Func1) return helper.invoke1;
> >   if (callback is _Func0) return helper.invoke0;
> > }
> > 
> > We could even add more options (like definitions that accept optional
> arguments
> > and everything!)
> 
> I tried this awhile ago and failed because of checked mode not liking classes
> with call method in some contexts. Certainly a place to investigate. ... in
> another CL :-)

yeah - exactly, I remember trying and failing with that too, but if we don't
generalize it to support named arguments, and just focus on merging the 3 apis
here, I think we can do it with the trick above :)