pkg/unittest: more lock-down, cleanup

pkg/unittest/lib/html_enhanced_config.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * A simple unit test library for running tests in a browser.
  *
  * Provides enhanced HTML output with collapsible group headers
  * and other at-a-glance information about the test results.
  */
@@ skipping 49 matching lines @@
     if ('unittest-suite-external-error' == e.data) {
       handleExternalError('<unknown>', '(external error detected)');
     }
   }
 
   void onInit() {
     _installHandlers();
     //initialize and load CSS
     final String _CSSID = '_unittestcss_';
 
-    var cssElement = document.head.query('#${_CSSID}');
+    var cssElement = document.head.querySelector('#${_CSSID}');
     if (cssElement == null) {
       cssElement = new StyleElement();
       cssElement.id = _CSSID;
       document.head.append(cssElement);
     }
 
     cssElement.text = _htmlTestCSS;
     window.postMessage('unittest-suite-wait-for-done', '*');
   }
 
@@ skipping 46 matching lines @@
             <span class='unittest-error'>
             ${errors + (uncaughtError == null ? 0 : 1)} errors</span>
           </div>"""));
       }
 
       te.children.add(new Element.html("""
         <div><button id='btnCollapseAll'>Collapse All</button></div>
        """));
 
       // handle the click event for the collapse all button
-      te.query('#btnCollapseAll').onClick.listen((_){
+      te.querySelector('#btnCollapseAll').onClick.listen((_){
         document
-          .queryAll('.unittest-row')
+          .querySelectorAll('.unittest-row')
           .forEach((el) => el.attributes['class'] = el.attributes['class']
               .replaceAll('unittest-row ', 'unittest-row-hidden '));
       });
 
       var previousGroup = '';
       var groupPassFail = true;
       final indentAmount = 50;
 
       // order by group and sort numerically within each group
       var groupedBy = new LinkedHashMap<String, List<TestCase>>();
@@ skipping 50 matching lines @@
                 </div>
                 <div ${_isIE ? "style='display:inline-block' ": ""}>
                     ${test_.currentGroup}</div>
                 &nbsp;
                 <div ${_isIE ? "style='display:inline-block' ": ""}>
                     (${groupTestPassedCount}/${groupTotalTestCount})</div>
               </div>
             </div>"""));
 
           // 'safeGroup' could be empty
-          var grp = (safeGroup == '') ? null : te.query('#${safeGroup}');
+          var grp = (safeGroup == '') ? null : te.querySelector('#${safeGroup}');

[Siggi Cherem (dart-lang), 2014/02/03 18:09:46]

80

[kevmoo, 2014/02/03 18:22:57]

Done.

           if (grp != null) {
             grp.onClick.listen((_) {
-              var row = document.query('.unittest-row-${safeGroup}');
+              var row = document.querySelector('.unittest-row-${safeGroup}');
               if (row.attributes['class'].contains('unittest-row ')){
-                document.queryAll('.unittest-row-${safeGroup}').forEach(
+                document.querySelectorAll('.unittest-row-${safeGroup}').forEach(
                     (e) => e.attributes['class'] =  e.attributes['class']
                         .replaceAll('unittest-row ', 'unittest-row-hidden '));
               }else{
-                document.queryAll('.unittest-row-${safeGroup}').forEach(
+                document.querySelectorAll('.unittest-row-${safeGroup}').forEach(
                     (e) => e.attributes['class'] = e.attributes['class']
                         .replaceAll('unittest-row-hidden', 'unittest-row'));
               }
             });
           }
         }
 
         _buildRow(test_, te, safeGroup, !groupPassFail);
       }
 
@@ skipping 180 matching lines @@
 
   ''';
 }
 
 void useHtmlEnhancedConfiguration([bool isLayoutTest = false]) {
   unittestConfiguration = isLayoutTest ? _singletonLayout : _singletonNotLayout;
 }
 
 final _singletonLayout = new HtmlEnhancedConfiguration(true);
 final _singletonNotLayout = new HtmlEnhancedConfiguration(false);