Smarter splitting around named collection arguments.

Smarter splitting around named collection arguments.

Fix #394.

R=kevmoo@google.com

Committed: https://github.com/dart-lang/dart_style/commit/71f72b9a1b5ba6987a35228b019fefbe2b0190c1

[Bob Nystrom, 2015-12-02 00:49:49]

rnystrom@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2015-12-02 01:11:57]

LGTM - ish

I'm not 100% sold on this change. I kinda like knowing that if args are broken
across lines, I don't need to look at the call site to find args

Is this a big win is cases we care about?

[Bob Nystrom, 2015-12-02 18:52:02]

On 2015/12/02 01:11:57, kevmoo wrote:
> LGTM - ish
> 
> I'm not 100% sold on this change. I kinda like knowing that if args are broken
> across lines, I don't need to look at the call site to find args

I didn't follow what you mean here.

> Is this a big win is cases we care about?

I think so. It does look a little weird when you have multiple named arguments
that don't get indented, like:

function(named: [
  ...
], another: [
  ...
]);

Though I think that case is useful to support. The real motivation is cases like
394. With this change, it's:

return $.Div(inner: [
  $.Div(id: "container", inner: [
    $.Canvas(width: maxD, height: maxD, clazz: "center", ref: canvas),
    $.Form(clazz: "center", inner: [
      $.Input(type: "range", max: 1000, value: seeds, onChange: onSliderChange)
    ]),
    $.Img(src: "math.png", width: "350px", height: "42px", clazz: "center")
  ]),
  $.Footer(inner: [$.P(id: "notes", inner: "${seeds} seeds")]),
]);

Without it, you get:

return $.Div(
    inner: [
  $.Div(
      id: "container",
      inner: [
    $.Canvas(width: maxD, height: maxD, clazz: "center", ref: canvas),
    $.Form(
        clazz: "center",
        inner: [
      $.Input(type: "range", max: 1000, value: seeds, onChange: onSliderChange)
    ]),
    $.Img(src: "math.png", width: "350px", height: "42px", clazz: "center")
  ]),
  $.Footer(inner: [$.P(id: "notes", inner: "${seeds} seeds")]),
]);

[Bob Nystrom, 2015-12-02 18:52:43]

Description was changed from

==========
Smarter splitting around named collection arguments.

Fix #394.
==========

to

==========
Smarter splitting around named collection arguments.

Fix #394.

R=kevmoo@google.com

Committed:
https://github.com/dart-lang/dart_style/commit/71f72b9a1b5ba6987a35228b019fef...
==========

[Bob Nystrom, 2015-12-02 18:52:45]

Committed patchset #1 (id:1) manually as
71f72b9a1b5ba6987a35228b019fefbe2b0190c1 (presubmit successful).