| OLD | NEW |
|---|
| 1 40 columns | | 1 40 columns | |
| 2 >>> args before and after list forces nesting | 2 >>> args before and after list forces nesting |
| 3 method(first,[element, element, element, element],third); | 3 method(first,[element, element, element, element],third); |
| 4 <<< | 4 <<< |
| 5 method( | 5 method( |
| 6 first, | 6 first, |
| 7 [ | 7 [ |
| 8 element, | 8 element, |
| 9 element, | 9 element, |
| 10 element, | 10 element, |
| (...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 266 element, | 266 element, |
| 267 element, | 267 element, |
| 268 element, | 268 element, |
| 269 element | 269 element |
| 270 ], b: [ | 270 ], b: [ |
| 271 element, | 271 element, |
| 272 element, | 272 element, |
| 273 element, | 273 element, |
| 274 element | 274 element |
| 275 ]); | 275 ]); |
| 276 >>> nest trailing named if there are non-body named | 276 >>> allow leadining non-collection to not split |
| 277 longFunctionName(a: argument, b: argument, | 277 longFunctionName(a: arg, b: arg, |
| 278 c: [element, element, element, element], d: [element, element, element, element]
); | 278 c: [element, element, element, element], d: [element, element, element, element]
); |
| 279 <<< | 279 <<< |
| 280 longFunctionName(a: arg, b: arg, c: [ |
| 281 element, |
| 282 element, |
| 283 element, |
| 284 element |
| 285 ], d: [ |
| 286 element, |
| 287 element, |
| 288 element, |
| 289 element |
| 290 ]); |
| 291 >>> don't allow splitting before first arg while splitting collections |
| 292 longFunctionName( |
| 293 a: argument, b: argument, c: [ |
| 294 element, |
| 295 element, |
| 296 element, |
| 297 element |
| 298 ], d: [ |
| 299 element, |
| 300 element, |
| 301 element, |
| 302 element |
| 303 ]); |
| 304 <<< |
| 280 longFunctionName( | 305 longFunctionName( |
| 281 a: argument, | 306 a: argument, |
| 282 b: argument, | 307 b: argument, |
| 283 c: [ | 308 c: [ |
| 284 element, | 309 element, |
| 285 element, | 310 element, |
| 286 element, | 311 element, |
| 287 element | 312 element |
| 288 ], | 313 ], |
| 289 d: [ | 314 d: [ |
| 290 element, | 315 element, |
| 291 element, | 316 element, |
| 292 element, | 317 element, |
| 293 element | 318 element |
| 294 ]); | 319 ]); |
| 320 >>> trailing named arguments that do not split |
| 321 longFunctionName(a: [element, element, element, element], |
| 322 b: [element, element, element, element], c: argument, d: argument); |
| 323 <<< |
| 324 longFunctionName(a: [ |
| 325 element, |
| 326 element, |
| 327 element, |
| 328 element |
| 329 ], b: [ |
| 330 element, |
| 331 element, |
| 332 element, |
| 333 element |
| 334 ], c: argument, d: argument); |
| 335 >>> trailing named arguments that do split |
| 336 longFunctionName(a: [element, element, element, element], |
| 337 b: [element, element, element, element], c: argument, d: argument, e: argument); |
| 338 <<< |
| 339 longFunctionName( |
| 340 a: [ |
| 341 element, |
| 342 element, |
| 343 element, |
| 344 element |
| 345 ], |
| 346 b: [ |
| 347 element, |
| 348 element, |
| 349 element, |
| 350 element |
| 351 ], |
| 352 c: argument, |
| 353 d: argument, |
| 354 e: argument); |
| 295 >>> leading named arguments | 355 >>> leading named arguments |
| 296 longFunctionName(name1: [element, element], name2: [element, element], name3: ar
gument, name4: argument); | 356 longFunctionName(name1: [element, element], name2: [element, element], name3: ar
gument, name4: argument); |
| 297 <<< | 357 <<< |
| 298 longFunctionName( | 358 longFunctionName( |
| 299 name1: [element, element], | 359 name1: [element, element], |
| 300 name2: [element, element], | 360 name2: [element, element], |
| 301 name3: argument, | 361 name3: argument, |
| 302 name4: argument); | 362 name4: argument); |
| 303 >>> don't nest because of nested 1-arg fn | 363 >>> don't nest because of nested 1-arg fn |
| 304 outer(inner([element, element, element, element])); | 364 outer(inner([element, element, element, element])); |
| (...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 368 [element] | 428 [element] |
| 369 ]); | 429 ]); |
| 370 >>> comment before collection | 430 >>> comment before collection |
| 371 function(argument, // comment | 431 function(argument, // comment |
| 372 [[element]]); | 432 [[element]]); |
| 373 <<< | 433 <<< |
| 374 function(argument, // comment | 434 function(argument, // comment |
| 375 [ | 435 [ |
| 376 [element] | 436 [element] |
| 377 ]); | 437 ]); |
| OLD | NEW |
|---|
Chromium Code Reviews
Issue 1493553002:
Smarter splitting around named collection arguments. (Closed)
Base URL: https://github.com/dart-lang/dart_style.git@master