Issue 14917020: Inline _OneByteString._setAt. The key knowledge is that _setAt is an internal method that has to be…

Issue 14917020: Inline _OneByteString._setAt. The key knowledge is that _setAt is an internal method that has to be… (Closed)

Created:
7 years, 7 months ago by srdjan

Modified:
7 years, 7 months ago

Reviewers:
zra, Florian Schneider

CC:
reviews_dartlang.org, zra

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Inline _OneByteString._setAt. The key knowledge is that _setAt is an internal method that has to be called with correct arguments, therefore no checks are needed. R=fschneider@google.com, zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=22528

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -19 lines)			Patch
M	runtime/lib/string_patch.dart	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/assembler_arm.cc	View	1 2 3 4 5 6	1 chunk	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2 3 4 5	1 chunk	+30 lines, -12 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 2 3 4	3 chunks	+4 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3 4	3 chunks	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 2 3 4	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2 3 4	3 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

LGTM. https://codereview.chromium.org/14917020/diff/12001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/14917020/diff/12001/runtime/vm/flow_graph_optimizer.cc#newcode1607 runtime/vm/flow_graph_optimizer.cc:1607: } else if (recognized_kind == MethodRecognizer::kOneByteStringSetAt) { You ...

7 years, 7 months ago (2013-05-08 12:44:10 UTC) #2

srdjan

Zach can you please review the simarm on Mac fix . https://codereview.chromium.org/14917020/diff/12001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): ...

7 years, 7 months ago (2013-05-08 19:10:57 UTC) #3

srdjan

7 years, 7 months ago (2013-05-08 20:03:43 UTC) #5

Message was sent while issue was closed.

Committed patchset #7 manually as r22528 (presubmit successful).

Expand Messages | Collapse Messages