runtime/vm/intermediate_language_ia32.cc - Issue 14917020: Inline _OneByteString._setAt. The key knowledge is that _setAt is an internal method that has to be…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 14917020: Inline _OneByteString._setAt. The key knowledge is that _setAt is an internal method that has to be… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_ia32.cc

===================================================================

--- runtime/vm/intermediate_language_ia32.cc (revision 22522)

+++ runtime/vm/intermediate_language_ia32.cc (working copy)

@@ -1345,6 +1345,7 @@

ASSERT(idx == 2);

switch (class_id_) {

case kArrayCid:

+ case kOneByteStringCid:

case kTypedDataInt8ArrayCid:

case kTypedDataUint8ArrayCid:

case kExternalTypedDataUint8ArrayCid:

@@ -1398,6 +1399,7 @@

case kTypedDataInt8ArrayCid:

case kTypedDataUint8ArrayCid:

case kTypedDataUint8ClampedArrayCid:

+ case kOneByteStringCid:

// TODO(fschneider): Add location constraint for byte registers (EAX,

// EBX, ECX, EDX) instead of using a fixed register.

locs->set_in(2, Location::FixedRegisterOrSmiConstant(value(), EAX));

@@ -1474,6 +1476,7 @@

case kTypedDataInt8ArrayCid:

case kTypedDataUint8ArrayCid:

case kExternalTypedDataUint8ArrayCid:

+ case kOneByteStringCid:

if (locs()->in(2).IsConstant()) {

const Smi& constant = Smi::Cast(locs()->in(2).constant());

__ movb(element_address,

« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »