Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1491263003: Fix a bunch of tests. (Closed)

Created:
5 years ago by nweiz
Modified:
5 years ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -54 lines) Patch
M test/get/hosted/do_not_upgrade_on_removed_constraints_test.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M test/hosted/remove_removed_transitive_dependency_test.dart View 3 chunks +9 lines, -9 lines 0 comments Download
M test/transformer/fails_to_load_a_transform_with_an_import_error_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/upgrade/git/do_not_upgrade_if_unneeded_test.dart View 3 chunks +12 lines, -12 lines 0 comments Download
M test/upgrade/hosted/upgrade_removed_constraints_test.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M test/validator/name_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
5 years ago (2015-12-03 00:07:12 UTC) #1
Bob Nystrom
lgtm
5 years ago (2015-12-03 00:08:20 UTC) #2
nweiz
5 years ago (2015-12-03 00:45:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e997069e5ea489d5d8d9e3f0d1c1f80248a1e22a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698