Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: test/validator/name_test.dart

Issue 1491263003: Fix a bunch of tests. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/upgrade/hosted/upgrade_removed_constraints_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/validator/name_test.dart
diff --git a/test/validator/name_test.dart b/test/validator/name_test.dart
index 83b5701c8134075a3af8dcb77cbd4b5312f94c55..926080439aa1ba5f38db9b2aad2c1d441b030cf1 100644
--- a/test/validator/name_test.dart
+++ b/test/validator/name_test.dart
@@ -46,31 +46,11 @@ main() {
group('should consider a package invalid if it', () {
setUp(d.validPackage.create);
- integration('has an empty package name', () {
- d.dir(appPath, [d.libPubspec("", "1.0.0")]).create();
- expectValidationError(name);
- });
-
- integration('has a package name with an invalid character', () {
- d.dir(appPath, [d.libPubspec("test-pkg", "1.0.0")]).create();
- expectValidationError(name);
- });
-
- integration('has a package name that begins with a number', () {
- d.dir(appPath, [d.libPubspec("8ball", "1.0.0")]).create();
- expectValidationError(name);
- });
-
integration('has a package name that contains upper-case letters', () {
d.dir(appPath, [d.libPubspec("TestPkg", "1.0.0")]).create();
expectValidationWarning(name);
});
- integration('has a package name that is a Dart reserved word', () {
- d.dir(appPath, [d.libPubspec("final", "1.0.0")]).create();
- expectValidationError(name);
- });
-
integration('has a library name with an invalid character', () {
d.dir(appPath, [
d.libPubspec("test_pkg", "1.0.0"),
« no previous file with comments | « test/upgrade/hosted/upgrade_removed_constraints_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698