Log the type of exceptions caught by pub.

Log the type of exceptions caught by pub.

We're seeing some user reports of exceptions where the type is
ambiguous.

R=rnystrom@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=32092

[Bob Nystrom, 2014-01-28 21:23:57]

https://codereview.chromium.org/149063002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command.dart (right):

https://codereview.chromium.org/149063002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command.dart:132: log.fine("Exception type:
${error.runtimeType}");
It seems like we're just making work for ourselves. Maybe we should just log the
full toString() of the exception and be OK with showing the user the type name?

[nweiz, 2014-01-28 22:13:36]

https://codereview.chromium.org/149063002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command.dart (right):

https://codereview.chromium.org/149063002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command.dart:132: log.fine("Exception type:
${error.runtimeType}");
On 2014/01/28 21:23:57, Bob Nystrom wrote:
> It seems like we're just making work for ourselves. Maybe we should just log
the
> full toString() of the exception and be OK with showing the user the type
name?

Only certain "dart:" exceptions contain their types. The types of other
exceptions would still be unavailable. And the reasoning behind not showing the
"dart:" exception types is still sound -- it's confusing and not useful for end
users. Only showing it with "--verbose" or "--trace" hits our use cases better.

[Bob Nystrom, 2014-01-28 22:39:05]

lgtm

[nweiz, 2014-01-28 22:52:46]

Committed patchset #1 manually as r32092 (presubmit successful).