Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2588)

Unified Diff: sdk/lib/_internal/pub/lib/src/command.dart

Issue 149063002: Log the type of exceptions caught by pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/lib/src/command.dart
diff --git a/sdk/lib/_internal/pub/lib/src/command.dart b/sdk/lib/_internal/pub/lib/src/command.dart
index b36cae4409859a61397ac218d4249ed71c815fdb..a6823384bef9a502fccfe4701087a2d25e110909 100644
--- a/sdk/lib/_internal/pub/lib/src/command.dart
+++ b/sdk/lib/_internal/pub/lib/src/command.dart
@@ -129,6 +129,7 @@ abstract class PubCommand {
var message;
log.error(getErrorMessage(error));
+ log.fine("Exception type: ${error.runtimeType}");
Bob Nystrom 2014/01/28 21:23:57 It seems like we're just making work for ourselves
nweiz 2014/01/28 22:13:37 Only certain "dart:" exceptions contain their type
if (options['trace'] || !isUserFacingException(error)) {
log.error(chain.terse);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698