Issue 14856021: Report UNDEFINED_CONSTRUCTOR_IN_INITIALIZER and others

Issue 14856021: Report UNDEFINED_CONSTRUCTOR_IN_INITIALIZER and others (Closed)

Created:
7 years, 7 months ago by scheglov

Modified:
7 years, 7 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report UNDEFINED_CONSTRUCTOR_IN_INITIALIZER and others R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22855

Patch Set 1 #

Total comments: 6

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+231 lines, -22 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java	View	2 chunks	+18 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java	View	3 chunks	+19 lines, -6 lines	6 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java	View	1 chunk	+16 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java	View	2 chunks	+50 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View	3 chunks	+63 lines, -9 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java	View	2 chunks	+65 lines, -0 lines	0 comments	Download
M	tests/co19/co19-analyzer.status	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/14856021/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java (right): https://codereview.chromium.org/14856021/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java#newcode705 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java:705: * @param interfaceType the interface type to create ...

7 years, 7 months ago (2013-05-17 14:10:25 UTC) #2

scheglov

Committed patchset #1 manually as r22855 (presubmit successful).

7 years, 7 months ago (2013-05-17 16:09:12 UTC) #3

scheglov

7 years, 7 months ago (2013-05-17 16:09:46 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/14856021/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java
(right):

https://codereview.chromium.org/14856021/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java:705:
* @param interfaceType the interface type to create default constructor for
On 2013/05/17 14:10:25, Brian Wilkerson wrote:
> Perhaps: the interface type for which to create a default constructor

Done.

https://codereview.chromium.org/14856021/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java:706:
* @return the {@link ConstructorElement}s array with the single default
constructor element.
On 2013/05/17 14:10:25, Brian Wilkerson wrote:
> nit: delete period

Done.

https://codereview.chromium.org/14856021/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java:708:
private ConstructorElement[] createDefaulsConstructors(InterfaceTypeImpl
interfaceType) {
On 2013/05/17 14:10:25, Brian Wilkerson wrote:
> "Defauls" --> "Default"

Done.

Expand Messages | Collapse Messages