Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java

Issue 14856021: Report UNDEFINED_CONSTRUCTOR_IN_INITIALIZER and others (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java
diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java
index 510591592dece8bd90be68e9e056d92da98fd895..f9aff510a8b7483d8ce5dd90b51aaec513f57b45 100644
--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java
+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java
@@ -976,8 +976,23 @@ public class ElementResolver extends SimpleASTVisitor<Void> {
element = superclass.getNamedConstructor(name.getName());
}
if (element == null) {
- // TODO(brianwilkerson) Report this error and decide what element to associate with the node.
+ if (name != null) {
+ resolver.reportError(
+ CompileTimeErrorCode.UNDEFINED_CONSTRUCTOR_IN_INITIALIZER,
+ node,
+ superclass.getName(),
+ name);
+ } else {
+ resolver.reportError(
+ CompileTimeErrorCode.UNDEFINED_CONSTRUCTOR_IN_INITIALIZER_DEFAULT,
+ node,
+ superclass.getName());
+ }
return null;
+ } else {
+ if (element.isFactory()) {
+ resolver.reportError(CompileTimeErrorCode.NON_GENERATIVE_CONSTRUCTOR, node, element);
+ }
}
if (name != null) {
recordResolution(name, element);

Powered by Google App Engine
This is Rietveld 408576698