Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 148453003: Updating Angular version (Closed)

Created:
6 years, 11 months ago by blois
Modified:
6 years, 11 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Updating Angular version We missed some Angular-breaking changes because the parser tests were marked as failing due to some known Angular/Dart1.1 incompatibilities, but those have been fixed in Angular. Updating to this version has the parser tests passing cleanly. Only manual change was to the pkg.status file. BUG= R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=32035

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5456 lines, -9027 lines) Patch
M pkg/pkg.status View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/third_party/angular_tests/browser_test.dart View 2 chunks +123 lines, -108 lines 0 comments Download
M third_party/pkg/angular/.gitignore View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/pkg/angular/.travis.yml View 1 chunk +27 lines, -0 lines 0 comments Download
M third_party/pkg/angular/CHANGELOG.md View 1 chunk +89 lines, -0 lines 0 comments Download
A third_party/pkg/angular/CONTRIBUTING.md View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/pkg/angular/README.md View 3 chunks +10 lines, -3 lines 0 comments Download
M third_party/pkg/angular/REVISION View 1 chunk +1 line, -1 line 0 comments Download
M third_party/pkg/angular/analyze.sh View 1 chunk +2 lines, -27 lines 0 comments Download
M third_party/pkg/angular/bin/parser_generator_for_spec.dart View 5 chunks +22 lines, -8 lines 0 comments Download
D third_party/pkg/angular/cla.md View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/pkg/angular/dartium.sh View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/pkg/angular/demo/README.md View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/pkg/angular/demo/bouncing_balls/pubspec.yaml View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/pkg/angular/demo/helloworld/helloworld.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/pkg/angular/demo/helloworld/pubspec.yaml View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/pkg/angular/demo/pubspec.yaml View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/pkg/angular/demo/todo/README.md View 1 chunk +3 lines, -3 lines 0 comments Download
D third_party/pkg/angular/demo/todo/bootstrap.css View 1 chunk +0 lines, -6167 lines 0 comments Download
D third_party/pkg/angular/demo/todo/index.html View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/pkg/angular/demo/todo/main.dart View 1 chunk +0 lines, -37 lines 0 comments Download
M third_party/pkg/angular/demo/todo/pubspec.yaml View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/pkg/angular/demo/todo/todo.css View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/pkg/angular/demo/todo/todo.dart View 1 chunk +0 lines, -93 lines 0 comments Download
A + third_party/pkg/angular/demo/todo/web/bootstrap.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/pkg/angular/demo/todo/web/index.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/pkg/angular/demo/todo/web/main.dart View 1 chunk +6 lines, -0 lines 0 comments Download
A + third_party/pkg/angular/demo/todo/web/todo.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/pkg/angular/demo/todo/web/todo.dart View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/pkg/angular/demo/web/book.css View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/pkg/angular/demo/web/book.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/pkg/angular/demo/web/index.html View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/pkg/angular/demo/web/main.dart View 1 chunk +0 lines, -82 lines 0 comments Download
D third_party/pkg/angular/demo/web/pubspec.yaml View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/pkg/angular/genDocs.sh View 1 chunk +2 lines, -7 lines 0 comments Download
M third_party/pkg/angular/generate.sh View 1 chunk +2 lines, -8 lines 0 comments Download
M third_party/pkg/angular/karma-perf.conf.js View 1 chunk +1 line, -1 line 0 comments Download
D third_party/pkg/angular/karma-snapshot.sh View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/pkg/angular/karma.conf.js View 2 chunks +8 lines, -2 lines 0 comments Download
M third_party/pkg/angular/lib/angular.dart View 1 chunk +37 lines, -3 lines 0 comments Download
M third_party/pkg/angular/lib/bootstrap.dart View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/pkg/angular/lib/core/directive.dart View 5 chunks +30 lines, -29 lines 0 comments Download
M third_party/pkg/angular/lib/core/filter.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/pkg/angular/lib/core/interpolate.dart View 3 chunks +11 lines, -8 lines 0 comments Download
M third_party/pkg/angular/lib/core/module.dart View 2 chunks +7 lines, -5 lines 0 comments Download
D third_party/pkg/angular/lib/core/parser/backend.dart View 1 chunk +0 lines, -362 lines 0 comments Download
M third_party/pkg/angular/lib/core/parser/characters.dart View 2 chunks +9 lines, -14 lines 0 comments Download
A third_party/pkg/angular/lib/core/parser/dynamic_parser.dart View 1 chunk +158 lines, -0 lines 0 comments Download
A third_party/pkg/angular/lib/core/parser/dynamic_parser_impl.dart View 1 chunk +301 lines, -0 lines 0 comments Download
A third_party/pkg/angular/lib/core/parser/eval.dart View 1 chunk +96 lines, -0 lines 0 comments Download
A third_party/pkg/angular/lib/core/parser/eval_access.dart View 1 chunk +210 lines, -0 lines 0 comments Download
A third_party/pkg/angular/lib/core/parser/eval_calls.dart View 1 chunk +121 lines, -0 lines 0 comments Download
M third_party/pkg/angular/lib/core/parser/lexer.dart View 7 chunks +88 lines, -69 lines 0 comments Download
M third_party/pkg/angular/lib/core/parser/parser.dart View 1 chunk +99 lines, -481 lines 0 comments Download
D third_party/pkg/angular/lib/core/parser/parser_library.dart View 1 chunk +0 lines, -19 lines 0 comments Download
M third_party/pkg/angular/lib/core/parser/static_parser.dart View 1 chunk +48 lines, -21 lines 0 comments Download
A third_party/pkg/angular/lib/core/parser/syntax.dart View 1 chunk +202 lines, -0 lines 0 comments Download
A third_party/pkg/angular/lib/core/parser/unparser.dart View 1 chunk +135 lines, -0 lines 0 comments Download
A third_party/pkg/angular/lib/core/parser/utils.dart View 1 chunk +96 lines, -0 lines 0 comments Download
M third_party/pkg/angular/lib/core/registry.dart View 2 chunks +41 lines, -5 lines 0 comments Download
M third_party/pkg/angular/lib/core/scope.dart View 17 chunks +177 lines, -22 lines 0 comments Download
M third_party/pkg/angular/lib/core_dom/block.dart View 5 chunks +7 lines, -16 lines 0 comments Download
M third_party/pkg/angular/lib/core_dom/block_factory.dart View 5 chunks +4 lines, -8 lines 0 comments Download
M third_party/pkg/angular/lib/core_dom/common.dart View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/pkg/angular/lib/core_dom/compiler.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/pkg/angular/lib/core_dom/cookies.dart View 7 chunks +17 lines, -32 lines 0 comments Download
M third_party/pkg/angular/lib/core_dom/directive.dart View 5 chunks +18 lines, -17 lines 0 comments Download
M third_party/pkg/angular/lib/core_dom/http.dart View 7 chunks +16 lines, -37 lines 0 comments Download
M third_party/pkg/angular/lib/core_dom/module.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/pkg/angular/lib/core_dom/node_cursor.dart View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/pkg/angular/lib/core_dom/selector.dart View 8 chunks +28 lines, -18 lines 0 comments Download
M third_party/pkg/angular/lib/directive/input_select.dart View 4 chunks +8 lines, -4 lines 0 comments Download
M third_party/pkg/angular/lib/directive/module.dart View 5 chunks +18 lines, -8 lines 0 comments Download
A third_party/pkg/angular/lib/directive/ng_control.dart View 1 chunk +56 lines, -0 lines 0 comments Download
M third_party/pkg/angular/lib/directive/ng_events.dart View 4 chunks +126 lines, -61 lines 0 comments Download
M third_party/pkg/angular/lib/directive/ng_form.dart View 1 chunk +186 lines, -4 lines 0 comments Download
M third_party/pkg/angular/lib/directive/ng_model.dart View 7 chunks +132 lines, -148 lines 0 comments Download
A third_party/pkg/angular/lib/directive/ng_model_validators.dart View 1 chunk +235 lines, -0 lines 0 comments Download
A third_party/pkg/angular/lib/directive/ng_pluralize.dart View 1 chunk +153 lines, -0 lines 0 comments Download
M third_party/pkg/angular/lib/directive/ng_src_boolean.dart View 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/pkg/angular/lib/directive/ng_style.dart View 1 chunk +1 line, -1 line 0 comments Download
M third_party/pkg/angular/lib/filter/limit_to.dart View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/pkg/angular/lib/filter/module.dart View 1 chunk +1 line, -1 line 0 comments Download
M third_party/pkg/angular/lib/filter/order_by.dart View 1 chunk +1 line, -1 line 0 comments Download
M third_party/pkg/angular/lib/introspection.dart View 3 chunks +14 lines, -11 lines 0 comments Download
M third_party/pkg/angular/lib/mock/debug.dart View 1 chunk +1 line, -1 line 0 comments Download
M third_party/pkg/angular/lib/mock/http_backend.dart View 1 chunk +16 lines, -7 lines 0 comments Download
M third_party/pkg/angular/lib/mock/module.dart View 1 chunk +1 line, -1 line 0 comments Download
M third_party/pkg/angular/lib/playback/playback_http.dart View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/pkg/angular/lib/routing/module.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/pkg/angular/lib/tools/expression_extractor.dart View 3 chunks +13 lines, -10 lines 0 comments Download
M third_party/pkg/angular/lib/tools/html_extractor.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/pkg/angular/lib/tools/io_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M third_party/pkg/angular/lib/tools/parser_generator/dart_code_gen.dart View 1 chunk +241 lines, -244 lines 0 comments Download
M third_party/pkg/angular/lib/tools/parser_generator/generator.dart View 2 chunks +59 lines, -33 lines 0 comments Download
D third_party/pkg/angular/lib/tools/parser_generator/source.dart View 1 chunk +0 lines, -92 lines 0 comments Download
M third_party/pkg/angular/lib/tools/parser_getter_setter/generator.dart View 1 chunk +69 lines, -58 lines 0 comments Download
M third_party/pkg/angular/lib/tools/selector.dart View 3 chunks +10 lines, -4 lines 0 comments Download
M third_party/pkg/angular/lib/tools/source_crawler_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M third_party/pkg/angular/lib/tools/source_metadata_extractor.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/pkg/angular/lib/tools/template_cache_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M third_party/pkg/angular/package.json View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/pkg/angular/perf/dom/compile_perf.dart View 1 chunk +1 line, -1 line 0 comments Download
M third_party/pkg/angular/perf/lexer_perf.dart View 1 chunk +1 line, -1 line 0 comments Download
M third_party/pkg/angular/perf/parser_perf.dart View 4 chunks +7 lines, -5 lines 0 comments Download
M third_party/pkg/angular/perf/scope_perf.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/pkg/angular/pubspec.yaml View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/pkg/angular/run-test.sh View 2 chunks +6 lines, -1 line 0 comments Download
A third_party/pkg/angular/scripts/analyze.sh View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/pkg/angular/scripts/changelog/authors.sh View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/pkg/angular/scripts/changelog/changelog.js View 1 chunk +206 lines, -0 lines 0 comments Download
A third_party/pkg/angular/scripts/changelog/changelog.spec.js View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/pkg/angular/scripts/env.sh View 1 chunk +28 lines, -0 lines 0 comments Download
A + third_party/pkg/angular/scripts/generate-documentation.sh View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/pkg/angular/scripts/generate-expressions.sh View 1 chunk +4 lines, -2 lines 0 comments Download
A + third_party/pkg/angular/scripts/karma/snapshot.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/pkg/angular/scripts/test-expression-extractor.sh View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/pkg/angular/scripts/travis/build.sh View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/pkg/angular/scripts/travis/setup.sh View 1 chunk +36 lines, -0 lines 0 comments Download
M third_party/pkg/angular/test/_specs.dart View 1 chunk +5 lines, -0 lines 0 comments Download
A + third_party/pkg/angular/test/core/core_directive_spec.dart View 3 chunks +22 lines, -2 lines 0 comments Download
M third_party/pkg/angular/test/core/parser/generated_functions.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/pkg/angular/test/core/parser/generated_getter_setter.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/pkg/angular/test/core/parser/generated_getter_setter_spec.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/pkg/angular/test/core/parser/generated_parser_spec.dart View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/pkg/angular/test/core/parser/lexer_spec.dart View 7 chunks +34 lines, -30 lines 0 comments Download
M third_party/pkg/angular/test/core/parser/parser_spec.dart View 5 chunks +82 lines, -20 lines 0 comments Download
M third_party/pkg/angular/test/core/parser/static_parser_spec.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/pkg/angular/test/core/registry_spec.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/pkg/angular/test/core/scope_spec.dart View 2 chunks +17 lines, -0 lines 0 comments Download
M third_party/pkg/angular/test/core_dom/compiler_spec.dart View 3 chunks +29 lines, -1 line 0 comments Download
M third_party/pkg/angular/test/core_dom/cookies_spec.dart View 6 chunks +16 lines, -9 lines 0 comments Download
M third_party/pkg/angular/test/core_dom/directive_spec.dart View 1 chunk +32 lines, -106 lines 0 comments Download
M third_party/pkg/angular/test/core_dom/http_spec.dart View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/pkg/angular/test/core_dom/selector_spec.dart View 4 chunks +11 lines, -0 lines 0 comments Download
M third_party/pkg/angular/test/core_dom/shadow_root_options_spec.dart View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/pkg/angular/test/directive/input_select_spec.dart View 2 chunks +23 lines, -1 line 0 comments Download
M third_party/pkg/angular/test/directive/ng_events_spec.dart View 2 chunks +26 lines, -1 line 0 comments Download
M third_party/pkg/angular/test/directive/ng_form_spec.dart View 1 chunk +282 lines, -28 lines 0 comments Download
M third_party/pkg/angular/test/directive/ng_model_spec.dart View 8 chunks +126 lines, -151 lines 0 comments Download
A third_party/pkg/angular/test/directive/ng_model_validators_spec.dart View 1 chunk +332 lines, -0 lines 0 comments Download
A third_party/pkg/angular/test/directive/ng_pluralize_spec.dart View 1 chunk +193 lines, -0 lines 0 comments Download
M third_party/pkg/angular/test/directive/ng_src_boolean_spec.dart View 1 chunk +42 lines, -0 lines 0 comments Download
M third_party/pkg/angular/test/directive/ng_switch_spec.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/pkg/angular/test/introspection_spec.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/pkg/angular/test/mock/http_backend_spec.dart View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/pkg/angular/test/tools/selector_spec.dart View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/pkg/angular/travis.md View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
6 years, 11 months ago (2014-01-27 22:02:06 UTC) #1
Siggi Cherem (dart-lang)
lgtm
6 years, 11 months ago (2014-01-27 22:27:13 UTC) #2
blois
6 years, 11 months ago (2014-01-27 22:29:38 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r32035 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698