Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: third_party/pkg/angular/lib/core_dom/http.dart

Issue 148453003: Updating Angular version (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/pkg/angular/lib/core_dom/http.dart
diff --git a/third_party/pkg/angular/lib/core_dom/http.dart b/third_party/pkg/angular/lib/core_dom/http.dart
index 2ac2d1380d0c7ddb992c4daceaa6119ac31f7f32..6adeb2ff418514f15f80dbf1d3e91d61cf504b4b 100644
--- a/third_party/pkg/angular/lib/core_dom/http.dart
+++ b/third_party/pkg/angular/lib/core_dom/http.dart
@@ -33,7 +33,8 @@ class HttpBackend {
mimeType: mimeType,
requestHeaders: requestHeaders,
sendData: sendData,
- onProgress: onProgress).then((x) => c.complete(x));
+ onProgress: onProgress).then((x) => c.complete(x),
+ onError: (e, stackTrace) => c.completeError(e, stackTrace));
return c.future;
}
}
@@ -49,7 +50,7 @@ typedef Response(HttpResponse);
typedef ResponseError(dynamic);
/**
-* HttpInterceptors are used to modify the Http request. They can be added to
+* HttpInterceptors are used to modify the Http request. They can be added to
* [HttpInterceptors] or passed into [Http.call].
*/
class HttpInterceptor {
@@ -100,7 +101,6 @@ class DefaultTransformDataHttpInterceptor implements HttpInterceptor {
};
Function requestError, responseError;
-
}
/**
@@ -163,30 +163,20 @@ class HttpResponseConfig {
Map headers;
var data;
-
-
var _headersObj;
/**
- * Header accessor. Given a string, it will return the matching header,
- * case-insentivitively. Without a string, returns a header object will
- * upper-case keys.
+ * Header accessor. Given a string, it will return the matching header,
+ * case-insentivitively. Without a string, returns a header object with
+ * lower-case keys.
*/
header([String name]) {
if (_headersObj == null) {
_headersObj = {};
- headers.forEach((k,v) {
- _headersObj[k.toLowerCase()] = v;
- });
+ headers.forEach((k,v) => _headersObj[k.toLowerCase()] = v);
}
- if (name != null) {
- name = name.toLowerCase();
- if (!_headersObj.containsKey(name)) return null;
- return _headersObj[name];
- }
-
- return _headersObj;
+ return name != null ? _headersObj[name.toLowerCase()] : _headersObj;
}
/**
@@ -242,13 +232,7 @@ class HttpResponse {
* header.
*/
headers([String key]) {
- if (key == null) {
- return _headers;
- }
- if (_headers.containsKey(key)) {
- return _headers[key];
- }
- return null;
+ return key == null ? _headers : _headers[key];
}
/**
@@ -505,16 +489,11 @@ class Http {
// Strip content-type if data is undefined
if (config.data == null) {
- List<String> toRemove = [];
- headers.forEach((h, _) {
- if (h.toUpperCase() == 'CONTENT-TYPE') {
- toRemove.add(h);
- };
- });
- toRemove.forEach((x) => headers.remove(x));
+ new List.from(headers.keys)
+ .where((h) => h.toUpperCase() == 'CONTENT-TYPE')
+ .forEach((h) => headers.remove(h));
}
-
return request(
null,
config: config,
@@ -661,15 +640,15 @@ class Http {
static Map<String, String> parseHeaders(dom.HttpRequest value) {
var headers = value.getAllResponseHeaders();
- var parsed = {}, key, val, i;
+ var parsed = {};
if (headers == null) return parsed;
headers.split('\n').forEach((line) {
- i = line.indexOf(':');
+ var i = line.indexOf(':');
if (i == -1) return;
- key = line.substring(0, i).trim().toLowerCase();
- val = line.substring(i + 1).trim();
+ var key = line.substring(0, i).trim().toLowerCase();
+ var val = line.substring(i + 1).trim();
if (key != '') {
if (parsed.containsKey(key)) {
« no previous file with comments | « third_party/pkg/angular/lib/core_dom/directive.dart ('k') | third_party/pkg/angular/lib/core_dom/module.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698