Issue 148273002: Fix bug in aliasing computation for constant index.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 148273002: Fix bug in aliasing computation for constant index. (Closed)

Created:
6 years, 11 months ago by Florian Schneider

Modified:
6 years, 10 months ago

Reviewers:
Vyacheslav Egorov (Google), Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View	1	1 chunk	+10 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

Florian Schneider

Committed patchset #2 manually as r32016 (presubmit successful).

6 years, 11 months ago (2014-01-27 12:02:42 UTC) #3

Ivan Posva

Was there a regression test added for this? Thanks, -Ivan

6 years, 10 months ago (2014-02-03 16:25:32 UTC) #4

Vyacheslav Egorov (Google)

6 years, 10 months ago (2014-02-03 16:56:40 UTC) #5

Message was sent while issue was closed.

It's not possible to add a unit test.Produced code was correct. The aliasing was
too conservative, not too optimistic.