Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1361)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 148273002: Fix bug in aliasing computation for constant index. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.cc
===================================================================
--- runtime/vm/flow_graph_optimizer.cc (revision 32014)
+++ runtime/vm/flow_graph_optimizer.cc (working copy)
@@ -5110,12 +5110,20 @@
return;
}
- // Constant indexes alias all non-constant indexes and non-constant
- // indexes alias all constant indexes. Ids start at 1.
+ // Constant indexes alias all non-constant indexes.
+ // Non-constant indexes alias all constant indexes.
+ // First update alias set for const-indices, then
+ // update set for all indices. Ids start at 1.
for (intptr_t id = 1; id <= max_index_id_; id++) {
BitVector* const_indexes = Get(Alias::ConstantIndex(id));
if (const_indexes != NULL) {
const_indexes->AddAll(indexes);
+ }
+ }
+
+ for (intptr_t id = 1; id <= max_index_id_; id++) {
+ BitVector* const_indexes = Get(Alias::ConstantIndex(id));
+ if (const_indexes != NULL) {
indexes->AddAll(const_indexes);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698