Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Issue 14791005: BREAKING CHANGE: enforce part of directive (Closed)

Created:
7 years, 7 months ago by hausner
Modified:
7 years, 7 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

BREAKING CHANGE: enforce part of directive For historical reasons, the VM is currently too lenient when parsing library parts. Files that get loaded through a 'part' directive must start with a 'part of libraryname;' clause. The VM so far has not reported an error if the clause is missing. This change enforces the grammar as the Spec mandates it. Library parts that do not start with 'part of' will no longer compile. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=22278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -33 lines) Patch
M runtime/vm/code_generator_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/compiler_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 5 chunks +5 lines, -1 line 0 comments Download
M runtime/vm/find_code_object_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/object_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 1 chunk +14 lines, -19 lines 0 comments Download
M runtime/vm/parser_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/empty_main.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/generic_instanceof.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/hello_script_lib_source.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/lazy_static6_src.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/library1_lib.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/library_prefixes.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/library_prefixes_test1.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/library_prefixes_test2.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/multi_pass2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/multi_pass_a.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/multi_pass_b.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/overridden_no_such_method.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/private1.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/private2.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/private2_lib.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/private2_main.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/private3.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/private_lib.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/private_main.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/private_other.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/top_level_entry.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/top_level_file1.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/top_level_file2.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/lib/crypto/hmac_sha1_test_vectors.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/lib/crypto/hmac_sha256_test_vectors.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
Many files, but the change is actually tiny.
7 years, 7 months ago (2013-05-01 20:25:34 UTC) #1
srdjan
lgtm
7 years, 7 months ago (2013-05-01 20:28:13 UTC) #2
hausner
7 years, 7 months ago (2013-05-01 20:47:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22278 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698