BREAKING CHANGE: enforce part of directive

runtime/vm/parser.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/parser.h"
 
 #include "lib/invocation_mirror.h"
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
@@ skipping 4421 matching lines @@
   while (CurrentToken() == Token::kPART) {
     ParseLibraryPart();
     metadata_pos = TokenPos();
     SkipMetadata();
   }
   SetPosition(metadata_pos);
 }
 
 
 void Parser::ParsePartHeader() {
-  intptr_t metadata_pos = TokenPos();
   SkipMetadata();
-  // TODO(hausner): Once support for old #source directive is removed
-  // from the compiler, add an error message here if we don't find
-  // a 'part of' directive.
-  if (CurrentToken() == Token::kPART) {
+  if (CurrentToken() != Token::kPART) {
+    ErrorMsg("'part of' expected");
+  }
+  ConsumeToken();
+  if (!IsLiteral("of")) {
+    ErrorMsg("'part of' expected");
+  }
+  ConsumeToken();
+  // The VM is not required to check that the library name matches the
+  // name of the current library, so we ignore it.
+  ExpectIdentifier("library name expected");
+  while (CurrentToken() == Token::kPERIOD) {
     ConsumeToken();
-    if (!IsLiteral("of")) {
-      ErrorMsg("'part of' expected");
-    }
-    ConsumeToken();
-    // The VM is not required to check that the library name matches the
-    // name of the current library, so we ignore it.
-    ExpectIdentifier("library name expected");
-    while (CurrentToken() == Token::kPERIOD) {
-      ConsumeToken();
-      ExpectIdentifier("malformed library name");
-    }
-    ExpectSemicolon();
-  } else {
-    SetPosition(metadata_pos);
+    ExpectIdentifier("malformed library name");
   }
+  ExpectSemicolon();
 }
 
 
 void Parser::ParseTopLevel() {
   TRACE_PARSER("ParseTopLevel");
   // Collect the classes found at the top level in this growable array.
   // They need to be registered with class finalization after parsing
   // has been completed.
   Isolate* isolate = Isolate::Current();
   ObjectStore* object_store = isolate->object_store();
@@ skipping 5484 matching lines @@
 void Parser::SkipQualIdent() {
   ASSERT(IsIdentifier());
   ConsumeToken();
   if (CurrentToken() == Token::kPERIOD) {
     ConsumeToken();  // Consume the kPERIOD token.
     ExpectIdentifier("identifier expected after '.'");
   }
 }
 
 }  // namespace dart