Issue 14781002: Inline remaining Float32x4 operations.

Issue 14781002: Inline remaining Float32x4 operations. (Closed)

Created:
7 years, 7 months ago by Cutch

Modified:
7 years, 7 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Inline remaining Float32x4 operations. BUG= R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=22277

Patch Set 3 : #

Total comments: 3

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+781 lines, -77 lines)			Patch
M	runtime/vm/flow_graph_optimizer.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2	2 chunks	+173 lines, -77 lines	3 comments	Download
M	runtime/vm/flow_graph_type_propagator.cc	View		1 chunk	+20 lines, -0 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View		1 chunk	+26 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View		4 chunks	+206 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View		1 chunk	+44 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View		1 chunk	+133 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View		1 chunk	+44 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View		1 chunk	+133 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Cutch

./tools/test.py -m all -a all --checked Test configurations: none_vm_debug_ia32_checked none_vm_release_ia32_checked none_vm_debug_x64_checked none_vm_release_x64_checked none_vm_debug_simarm_checked none_vm_release_simarm_checked none_vm_debug_simmips_checked ...

7 years, 7 months ago (2013-05-01 18:14:53 UTC) #2

srdjan

lgtm https://codereview.chromium.org/14781002/diff/4001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/14781002/diff/4001/runtime/vm/flow_graph_optimizer.cc#newcode1881 runtime/vm/flow_graph_optimizer.cc:1881: } This method has been become unwieldy. You ...

7 years, 7 months ago (2013-05-01 18:33:18 UTC) #3

Cutch

https://codereview.chromium.org/14781002/diff/4001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/14781002/diff/4001/runtime/vm/flow_graph_optimizer.cc#newcode1881 runtime/vm/flow_graph_optimizer.cc:1881: } On 2013/05/01 18:33:18, srdjan wrote: > This method ...

7 years, 7 months ago (2013-05-01 19:56:37 UTC) #4

srdjan

LGTM https://codereview.chromium.org/14781002/diff/8001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/14781002/diff/8001/runtime/vm/flow_graph_optimizer.cc#newcode1748 runtime/vm/flow_graph_optimizer.cc:1748: InstanceCallInstr* call, can call be const &?

7 years, 7 months ago (2013-05-01 20:02:24 UTC) #5

Cutch

https://codereview.chromium.org/14781002/diff/8001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/14781002/diff/8001/runtime/vm/flow_graph_optimizer.cc#newcode1748 runtime/vm/flow_graph_optimizer.cc:1748: InstanceCallInstr* call, On 2013/05/01 20:02:24, srdjan wrote: > can ...

7 years, 7 months ago (2013-05-01 20:11:18 UTC) #6

srdjan

7 years, 7 months ago (2013-05-01 20:18:41 UTC) #7

Cutch

7 years, 7 months ago (2013-05-01 20:40:36 UTC) #8

Message was sent while issue was closed.

Committed patchset #3 manually as r22277 (presubmit successful).

Expand Messages | Collapse Messages