Inline remaining Float32x4 operations.

runtime/vm/flow_graph_optimizer.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_optimizer.h"
 
 #include "vm/bit_vector.h"
 #include "vm/cha.h"
 #include "vm/flow_graph_builder.h"
 #include "vm/flow_graph_compiler.h"
@@ skipping 1784 matching lines @@
             new Float32x4ScaleInstr(recognized_kind, new Value(right),
                                     new Value(left), call);
         ReplaceCall(call, scale);
         return true;
       }
       case MethodRecognizer::kFloat32x4Sqrt:
       case MethodRecognizer::kFloat32x4ReciprocalSqrt:
       case MethodRecognizer::kFloat32x4Reciprocal: {
         Definition* left = call->ArgumentAt(0);
         AddCheckClass(left,
-              ICData::ZoneHandle(
-                  call->ic_data()->AsUnaryClassChecksForArgNr(0)),
-              call->deopt_id(),
-              call->env(),
-              call);
+                      ICData::ZoneHandle(
+                          call->ic_data()->AsUnaryClassChecksForArgNr(0)),
+                      call->deopt_id(),
+                      call->env(),
+                      call);
         Float32x4SqrtInstr* sqrt =
             new Float32x4SqrtInstr(recognized_kind, new Value(left), call);
         ReplaceCall(call, sqrt);
         return true;
       }
+      case MethodRecognizer::kFloat32x4WithX:
+      case MethodRecognizer::kFloat32x4WithY:
+      case MethodRecognizer::kFloat32x4WithZ:
+      case MethodRecognizer::kFloat32x4WithW: {
+        Definition* left = call->ArgumentAt(0);
+        Definition* right = call->ArgumentAt(1);
+        // Type check left.
+        AddCheckClass(left,
+                      ICData::ZoneHandle(
+                          call->ic_data()->AsUnaryClassChecksForArgNr(0)),
+                      call->deopt_id(),
+                      call->env(),
+                      call);
+        Float32x4WithInstr* with = new Float32x4WithInstr(recognized_kind,
+                                                          new Value(left),
+                                                          new Value(right),
+                                                          call);
+        ReplaceCall(call, with);
+        return true;
+      }
+      case MethodRecognizer::kFloat32x4Absolute:
+      case MethodRecognizer::kFloat32x4Negate: {
+        Definition* left = call->ArgumentAt(0);
+        // Type check left.
+        AddCheckClass(left,
+                      ICData::ZoneHandle(
+                          call->ic_data()->AsUnaryClassChecksForArgNr(0)),
+                      call->deopt_id(),
+                      call->env(),
+                      call);
+        Float32x4ZeroArgInstr* zeroArg =
+            new Float32x4ZeroArgInstr(recognized_kind, new Value(left), call);
+        ReplaceCall(call, zeroArg);
+        return true;
+      }
+      case MethodRecognizer::kFloat32x4Clamp: {
+        Definition* left = call->ArgumentAt(0);
+        Definition* lower = call->ArgumentAt(1);
+        Definition* upper = call->ArgumentAt(2);
+        // Type check left.
+        AddCheckClass(left,
+                      ICData::ZoneHandle(
+                          call->ic_data()->AsUnaryClassChecksForArgNr(0)),
+                      call->deopt_id(),
+                      call->env(),
+                      call);
+        Float32x4ClampInstr* clamp = new Float32x4ClampInstr(new Value(left),
+                                                             new Value(lower),
+                                                             new Value(upper),
+                                                             call);
+        ReplaceCall(call, clamp);
+        return true;
+      }
+      case MethodRecognizer::kFloat32x4ToUint32x4: {
+        Definition* left = call->ArgumentAt(0);
+        // Type check left.
+        AddCheckClass(left,
+                      ICData::ZoneHandle(
+                          call->ic_data()->AsUnaryClassChecksForArgNr(0)),
+                      call->deopt_id(),
+                      call->env(),
+                      call);
+        Float32x4ToUint32x4Instr* cast =
+            new Float32x4ToUint32x4Instr(new Value(left), call);
+        ReplaceCall(call, cast);
+        return true;
+      }

[srdjan, 2013/05/01 18:33:18]

This method has been become unwieldy. You may consider factoring out code
specific for kFloat32x4Cid receiver.

[Cutch, 2013/05/01 19:56:37]

Done.

       default:
         return false;
     }
   }
   return false;
 }
 
 
 bool FlowGraphOptimizer::BuildByteArrayViewLoad(
     InstanceCallInstr* call,
@@ skipping 3105 matching lines @@
 void ConstantPropagator::VisitFloat32x4Scale(Float32x4ScaleInstr* instr) {
   SetValue(instr, non_constant_);
 }
 
 
 void ConstantPropagator::VisitFloat32x4Sqrt(Float32x4SqrtInstr* instr) {
   SetValue(instr, non_constant_);
 }
 
 
+void ConstantPropagator::VisitFloat32x4ZeroArg(Float32x4ZeroArgInstr* instr) {
+  SetValue(instr, non_constant_);
+}
+
+
+void ConstantPropagator::VisitFloat32x4Clamp(Float32x4ClampInstr* instr) {
+  SetValue(instr, non_constant_);
+}
+
+
+void ConstantPropagator::VisitFloat32x4With(Float32x4WithInstr* instr) {
+  SetValue(instr, non_constant_);
+}
+
+
+void ConstantPropagator::VisitFloat32x4ToUint32x4(
+    Float32x4ToUint32x4Instr* instr) {
+  SetValue(instr, non_constant_);
+}
+
+
 void ConstantPropagator::VisitMathSqrt(MathSqrtInstr* instr) {
   const Object& value = instr->value()->definition()->constant_value();
   if (IsNonConstant(value)) {
     SetValue(instr, non_constant_);
   } else if (IsConstant(value)) {
     // TODO(kmillikin): Handle sqrt.
     SetValue(instr, non_constant_);
   }
 }
 
@@ skipping 626 matching lines @@
   if (changed) {
     // We may have changed the block order and the dominator tree.
     flow_graph->DiscoverBlocks();
     GrowableArray<BitVector*> dominance_frontier;
     flow_graph->ComputeDominators(&dominance_frontier);
   }
 }
 
 
 }  // namespace dart