Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 14762003: Put "packages" directories in "benchmark". (Closed)

Created:
7 years, 7 months ago by Bob Nystrom
Modified:
7 years, 7 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Put "packages" directories in "benchmark". BUG=https://code.google.com/p/dart/issues/detail?id=9275 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=22447

Patch Set 1 #

Patch Set 2 : Show validation warning on "benchmarks". #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -115 lines) Patch
M sdk/lib/_internal/pub/lib/src/entrypoint.dart View 1 chunk +7 lines, -9 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/directory.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/pub_install_test.dart View 1 chunk +22 lines, -104 lines 0 comments Download
M sdk/lib/_internal/pub/test/validator/directory_test.dart View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
7 years, 7 months ago (2013-05-03 17:41:25 UTC) #1
nweiz
lgtm
7 years, 7 months ago (2013-05-06 23:08:49 UTC) #2
Bob Nystrom
7 years, 7 months ago (2013-05-07 00:03:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22447 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698