Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: sdk/lib/_internal/pub/test/validator/directory_test.dart

Issue 14762003: Put "packages" directories in "benchmark". (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Show validation warning on "benchmarks". Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sdk/lib/_internal/pub/test/install/pub_install_test.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'package:pathos/path.dart' as path; 5 import 'package:pathos/path.dart' as path;
6 import 'package:scheduled_test/scheduled_test.dart'; 6 import 'package:scheduled_test/scheduled_test.dart';
7 7
8 import '../../lib/src/entrypoint.dart'; 8 import '../../lib/src/entrypoint.dart';
9 import '../../lib/src/validator.dart'; 9 import '../../lib/src/validator.dart';
10 import '../../lib/src/validator/directory.dart'; 10 import '../../lib/src/validator/directory.dart';
(...skipping 17 matching lines...) Expand all
28 d.dir("foo", [d.dir("tools")]) 28 d.dir("foo", [d.dir("tools")])
29 ]).create(); 29 ]).create();
30 expectNoValidationError(directory); 30 expectNoValidationError(directory);
31 }); 31 });
32 }); 32 });
33 33
34 group('should consider a package invalid if it has a top-level directory ' 34 group('should consider a package invalid if it has a top-level directory '
35 'named', () { 35 'named', () {
36 setUp(d.validPackage.create); 36 setUp(d.validPackage.create);
37 37
38 var names = ["tools", "tests", "docs", "examples", "sample", "samples"]; 38 var names = [
39 "benchmarks", "docs", "examples", "sample", "samples", "tests", "tools"
40 ];
41
39 for (var name in names) { 42 for (var name in names) {
40 integration('"$name"', () { 43 integration('"$name"', () {
41 d.dir(appPath, [d.dir(name)]).create(); 44 d.dir(appPath, [d.dir(name)]).create();
42 expectValidationWarning(directory); 45 expectValidationWarning(directory);
43 }); 46 });
44 } 47 }
45 }); 48 });
46 } 49 }
OLDNEW
« no previous file with comments | « sdk/lib/_internal/pub/test/install/pub_install_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698