Issue 14729013: Make sure we always unsubscribe from a stream, in http-impl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14729013: Make sure we always unsubscribe from a stream, in http-impl. (Closed)

Created:
7 years, 7 months ago by Anders Johnsen

Modified:
7 years, 7 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, Søren Gjesse

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Make sure we always unsubscribe from a stream, in http-impl. Fixes http_server_early_client_close test. BUG=https://code.google.com/p/dart/issues/detail?id=10408 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=22508

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
M	sdk/lib/io/http_impl.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
D	tests/standalone/io/http_server_early_client_close2_test.dart	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	tests/standalone/io/http_server_early_client_close_test.dart	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	tests/standalone/standalone.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

floitsch

LGTM. As discussed. Keep the test. More coverage is better.

7 years, 7 months ago (2013-05-08 14:45:13 UTC) #2

Anders Johnsen

7 years, 7 months ago (2013-05-08 14:46:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r22508 (presubmit successful).