sdk/lib/io/http_impl.dart - Issue 14729013: Make sure we always unsubscribe from a stream, in http-impl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/io/http_impl.dart

Issue 14729013: Make sure we always unsubscribe from a stream, in http-impl. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Add back a test. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/io/http_impl.dart

diff --git a/sdk/lib/io/http_impl.dart b/sdk/lib/io/http_impl.dart

index 32e03736b08da69347c3be8699814a5dd4b7e9bd..a0f514dc6fdfd8240f0768ccd73505a9994ac9c8 100644

--- a/sdk/lib/io/http_impl.dart

+++ b/sdk/lib/io/http_impl.dart

@@ -567,6 +567,7 @@ class _HttpOutboundConsumer implements StreamConsumer {

onCancel: _onListen);

_outbound._addStream(_controller.stream)

.then((_) {

+ _onListen(); // Make sure we unsubscribe.

_done();

_closeCompleter.complete(_outbound);

« no previous file with comments | « no previous file | tests/standalone/io/http_server_early_client_close2_test.dart » ('j') | no next file with comments »