Issue 1471963002: Fix a bug with skipped groups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1471963002: Fix a bug with skipped groups. (Closed)

Created:
5 years ago by nweiz

Modified:
5 years ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix a bug with skipped groups. When a group was skipped, it was being filtered out entirely since it had no tests. This preserves it so that it can print a skip message. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/2c6807703a23ea947bfbb3452492fd287a941b85

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -2 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/src/backend/group.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/runner/compact_reporter_test.dart	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	test/runner/expanded_reporter_test.dart	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

kevmoo

LGTM don't forget to fix the version in pubspec whichever of these lands first

5 years ago (2015-11-24 01:14:37 UTC) #2

nweiz

On 2015/11/24 01:14:37, kevmoo wrote: > LGTM > > don't forget to fix the version ...

5 years ago (2015-11-24 01:56:56 UTC) #3

nweiz

5 years ago (2015-11-24 01:57:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2c6807703a23ea947bfbb3452492fd287a941b85 (presubmit successful).