Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: lib/src/backend/group.dart

Issue 1471963002: Fix a bug with skipped groups. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « CHANGELOG.md ('k') | test/runner/compact_reporter_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/backend/group.dart
diff --git a/lib/src/backend/group.dart b/lib/src/backend/group.dart
index dc7e6bd38c5f8f3ee607010b02c76f5568509a1b..f1b08a49e1d8000fdbbe2d640f2c675cf95a4ab3 100644
--- a/lib/src/backend/group.dart
+++ b/lib/src/backend/group.dart
@@ -44,14 +44,14 @@ class Group implements GroupEntry {
if (!metadata.testOn.evaluate(platform, os: os)) return null;
var newMetadata = metadata.forPlatform(platform, os: os);
var filtered = _map((entry) => entry.forPlatform(platform, os: os));
- if (filtered.isEmpty) return null;
+ if (filtered.isEmpty && !entries.isEmpty) return null;
return new Group(name, filtered,
metadata: newMetadata, setUpAll: setUpAll, tearDownAll: tearDownAll);
}
Group filter(bool callback(Test test)) {
var filtered = _map((entry) => entry.filter(callback));
- if (filtered.isEmpty) return null;
+ if (filtered.isEmpty && !entries.isEmpty) return null;
return new Group(name, filtered,
metadata: metadata, setUpAll: setUpAll, tearDownAll: tearDownAll);
}
« no previous file with comments | « CHANGELOG.md ('k') | test/runner/compact_reporter_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698