Issue 14718005: Print the number of failed tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14718005: Print the number of failed tests (Closed)

Created:
7 years, 7 months ago by kustermann

Modified:
7 years, 7 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org, ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Print the number of failed tests R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=22323

Patch Set 2 : #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -20 lines)			Patch
	M	tools/testing/dart/test_progress.dart	View	1	5 chunks	+14 lines, -20 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kustermann

I hope this cleans it a bit up. https://codereview.chromium.org/14718005/diff/4001/tools/testing/dart/test_progress.dart File tools/testing/dart/test_progress.dart (right): https://codereview.chromium.org/14718005/diff/4001/tools/testing/dart/test_progress.dart#newcode365 tools/testing/dart/test_progress.dart:365: print(_buildSummaryEnd(_failedTests)); ...

7 years, 7 months ago (2013-05-02 14:13:00 UTC) #1

ricow1

LGTM, I am fine with not printing that as default when not on buildbot

7 years, 7 months ago (2013-05-02 14:52:51 UTC) #2

kustermann

7 years, 7 months ago (2013-05-02 15:17:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r22323 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14718005: Print the number of failed tests (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages